Re: [asterisk-dev] [Code Review] 4419: SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 11

2015-02-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4419/#review14486 --- /branches/11/channels/sip/sdp_crypto.c

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/#review14489 --- Comments regarding recommended test cases for the chan_sip

Re: [asterisk-dev] [Code Review] 4419: SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 11

2015-02-18 Thread Mark Michelson
On Feb. 18, 2015, 7:57 p.m., Mark Michelson wrote: /branches/11/channels/sip/sdp_crypto.c, line 304 https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line304 Since we're only concerned about an integer value here, would the following work:

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-18 Thread Mark Michelson
On Feb. 18, 2015, 8:58 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/srtp-invite-double-crypto.xml, line 49 https://reviewboard.asterisk.org/r/4420/diff/1/?file=71426#file71426line49 The regex being used here has some issues.

[asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-18 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4431/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-18 Thread Moises Silva
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4431/#review14492 --- Ship it! Ship It! - Moises Silva On Feb. 18, 2015, 10:32

Re: [asterisk-dev] Adding the support for NACK in asterisk

2015-02-18 Thread Matthew Jordan
On Wed, Feb 18, 2015 at 7:02 PM, Matthew Jordan mjor...@digium.com wrote: On Tue, Feb 17, 2015 at 9:24 AM, Nitesh Bansal nitesh.ban...@gmail.com wrote: Hi Matt, It seems that my reply was lost in the pile of mails during holiday period? Is there any update on this? Regards, Nitesh

Re: [asterisk-dev] [Code Review] 4425: Create function to work around reference leaks caused by shutdown with pending scheduled events

2015-02-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4425/ --- (Updated Feb. 18, 2015, 7:59 p.m.) Status -- This change has been

Re: [asterisk-dev] Adding the support for NACK in asterisk

2015-02-18 Thread Matthew Jordan
On Tue, Feb 17, 2015 at 9:24 AM, Nitesh Bansal nitesh.ban...@gmail.com wrote: Hi Matt, It seems that my reply was lost in the pile of mails during holiday period? Is there any update on this? Regards, Nitesh On Tue, Dec 30, 2014 at 5:54 PM, Nitesh Bansal nitesh.ban...@gmail.com wrote: