---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4433/
---
(Updated Feb. 19, 2015, 12:42 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4430/
---
(Updated Feb. 19, 2015, 6:25 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4427/
---
(Updated Feb. 19, 2015, 12:25 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4433/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24811
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4435/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24813
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4436/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24814
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4435/#review14494
---
Ship it!
Minor preference nit.
/trunk/main/asterisk.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4436/#review14495
---
Ship it!
Ship It!
- rmudgett
On Feb. 19, 2015, 4:13 p.m.,
On Feb. 19, 2015, 5:26 p.m., rmudgett wrote:
/trunk/main/asterisk.c, line 1613
https://reviewboard.asterisk.org/r/4435/diff/1/?file=71478#file71478line1613
I prefer the
#if defined(SO_PASSCRED)
format as it allows more complicated expressions.
Will switch
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4370/
---
(Updated Feb. 19, 2015, 10:09 p.m.)
Review request for Asterisk
On Jan. 25, 2015, 11:36 p.m., Diederik de Groot wrote:
/branches/11/include/asterisk/inline_api.h, lines 44-51
https://reviewboard.asterisk.org/r/4370/diff/1/?file=71056#file71056line44
You might want to check out:
#define forceinline __inline__
On Feb. 4, 2015, 8:43 a.m., Joshua Colp wrote:
/branches/11/configure.ac, lines 1082-1085
https://reviewboard.asterisk.org/r/4370/diff/1/?file=71055#file71055line1082
If the compiler being used is clang I think this should be required
here and not just a warning when you actually
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4431/
---
(Updated Feb. 19, 2015, 10:52 p.m.)
Review request for Asterisk
On Feb. 19, 2015, 7:58 p.m., rmudgett wrote:
/branches/11/res/res_http_websocket.c, line 386
https://reviewboard.asterisk.org/r/4431/diff/1/?file=71469#file71469line386
Change to:
if (!--sanity) {
move after loop sanity check closing here.
}
Moving
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4433/#review14497
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 19, 2015, 7:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4422/
---
(Updated Feb. 19, 2015, 11:30 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4428/#review14493
---
Ship it!
Ship It!
- Joshua Colp
On Feb. 16, 2015, 6:58
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, line 290
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line290
Would
if (!strncmp(lifetime, 2^, 2))
accomplish the same thing here?
It should -
On Feb. 18, 2015, 2:58 p.m., Mark Michelson wrote:
/asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_nominal.csv,
lines 7-8
https://reviewboard.asterisk.org/r/4420/diff/1/?file=71424#file71424line7
I have no idea what difference this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4431/#review14498
---
/branches/11/res/res_http_websocket.c
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, lines 306-311
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line306
Should the decimal lifetime reading also ensure that the value is not
greater than 2^48?
Matt
Hi All,
I was evaluating the latest Asterisk (13.2.0) with the latest PJSIP (2.3) and
found a critical problem (critical if some of the endpoints enforce compliance
with the SIP RFC).
I had a discussion on pjsip mailing list about this
On Feb. 18, 2015, 1:57 p.m., Mark Michelson wrote:
/branches/11/channels/sip/sdp_crypto.c, line 304
https://reviewboard.asterisk.org/r/4419/diff/1/?file=71388#file71388line304
Since we're only concerned about an integer value here, would the
following work:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4419/
---
(Updated Feb. 19, 2015, 8:41 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4420/
---
(Updated Feb. 19, 2015, 8:59 p.m.)
Review request for Asterisk Developers
25 matches
Mail list logo
