Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

> On Feb. 26, 2015, 1:53 a.m., Ashley Sanders wrote: > > These are my findings regarding the first few sections of the document. On > > the technical-side, I have only made one small observation. All other > > observations are related to phrasing or a request for more information. At > > this

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/#review14556 --- These are my findings regarding the first few sections of the d

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/ --- (Updated Feb. 25, 2015, 5:48 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

> On Feb. 25, 2015, 6:15 p.m., Matt Jordan wrote: > > tags/11.7.0/main/stdtime/localtime.c, lines 482-484 > > > > > > I'm not sure why we are printing out to stderr here, but generally > > Asterisk does not do that

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/ --- (Updated Feb. 25, 2015, 3:49 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4418: SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 13

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4418/ --- (Updated Feb. 25, 2015, 9:13 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4419: SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 11

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4419/ --- (Updated Feb. 25, 2015, 3:13 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4431/ --- (Updated Feb. 25, 2015, 2:46 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/#review14554 --- Ship it! Ship It! - Joshua Colp On Feb. 20, 2015, 2:59 a.m.

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14553 --- tags/11.7.0/main/stdtime/localtime.c

Re: [asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4451/ --- (Updated Feb. 25, 2015, 5:57 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4447/#review14552 --- Ship it! Ship It! - Matt Jordan On Feb. 25, 2015, 10:21 a.m

Re: [asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4451/#review14551 --- Ship it! That is surprisingly small. Yay. /asterisk/trunk/li

[asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4451/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio

[asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24739 https://i

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4447/ --- (Updated Feb. 25, 2015, 10:21 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4447/#review14549 --- /branches/13/main/json.c

Re: [asterisk-dev] [Code Review] 4445: app_chanspy, channel: fix frame leaks

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4445/#review14548 --- Ship it! Ship It! - rmudgett On Feb. 24, 2015, 5:05 p.m., K

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4447/ --- (Updated Feb. 25, 2015, 9:27 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

On 25 Feb 2015, at 15:25, Joshua Colp wrote: > James Cloos wrote: >>> "J" == Joshua Colp writes: >> >> J> 2. Are there any higher level APIs that would be useful to have? >> >> In addition to the dns_naptr.h and dns_srv.h apis, there should be a >> similar dns_tlsa.h api. >> >> Even if

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

> On Feb. 24, 2015, 11:48 p.m., Mark Michelson wrote: > > First off, good page! It's pretty easy to follow the expected flow for DNS > > queries based on the API you've provided. From a low-level, there isn't > > much that's missing: you have ways of performing synchronous and > > asynchronous

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

> On Feb. 24, 2015, 5:48 p.m., Mark Michelson wrote: > > First off, good page! It's pretty easy to follow the expected flow for DNS > > queries based on the API you've provided. From a low-level, there isn't > > much that's missing: you have ways of performing synchronous and > > asynchronous

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

James Cloos wrote: "J" == Joshua Colp writes: J> 2. Are there any higher level APIs that would be useful to have? In addition to the dns_naptr.h and dns_srv.h apis, there should be a similar dns_tlsa.h api. Even if tlsa is not yet widespread, Asterisk's dns code should offer quality support

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/#review14545 --- >From James Cloos on the mailing list: In addition to the dns_