Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
On March 9, 2015, 1:19 p.m., Corey Farrell wrote: /branches/13/main/utils.c, line 614 https://reviewboard.asterisk.org/r/4463/diff/2/?file=71877#file71877line614 This looks like it should be applied to 11 as well. I'd go so far as to say that bug fixes as a result of this should be

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/#review14610 --- Do you plan on other chaotic things? As it is the chaos is

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-09 Thread yaron nahum
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4438/ --- (Updated March 9, 2015, 2:12 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14611 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 11:27

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/#review14613 --- /branches/13/include/asterisk/utils.h

Re: [asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4456/#review14612 --- Ship it! Ship It! - Joshua Colp On March 5, 2015, 11:34

Re: [asterisk-dev] [Code Review] 4455: res_pjsip: conflicting endpoint identifiers

2015-03-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4455/ --- (Updated March 9, 2015, 11:12 a.m.) Status -- This change has been

[asterisk-dev] Clustering the Asterisk Database (for fun and profit)

2015-03-09 Thread Matthew Jordan
Hey all - So, this last week I was travelling, and since flights are always a good time to write some code, I decided to play around with an idea that had been sitting in the back of my head for a little bit: clustering the Asterisk Database. I got the notion after looking at Kamailio's htable

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Scott Griepentrog
On March 9, 2015, 8:19 a.m., Corey Farrell wrote: /branches/13/main/utils.c, line 614 https://reviewboard.asterisk.org/r/4463/diff/2/?file=71877#file71877line614 This looks like it should be applied to 11 as well. Joshua Colp wrote: I'd go so far as to say that bug fixes as

[asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-09 Thread Justin T. Gibbs
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

2015-03-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4456/ --- (Updated March 9, 2015, 11:47 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Scott Griepentrog
On March 9, 2015, 7:41 a.m., Joshua Colp wrote: Do you plan on other chaotic things? As it is the chaos is really just memory allocation failures, nothing outside the scope of that. Yes -- the idea is that chaos could be easily inserted into any function that has a specific failure

[asterisk-dev] [Code Review] 4464: testsuite: Increase timeout for Asterisk shutdown

2015-03-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4464/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/ --- (Updated March 9, 2015, 3:50 p.m.) Review request for Asterisk

[asterisk-dev] [IAX] Need for LAGRQ and LAGRP

2015-03-09 Thread Yousf Ateya
While browsing some pcap captures of IAX channel, I found many LAGRQ and LAGRP packets (once per 10 seconds for each call). So, I traced LAGRQ and LAGRP use in code and found that it is almost useless; it sets iaxs[fr-callno]-lag which is not used anywhere else. Almost same functionality

[asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-09 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14617 --- Ship it! Ship It! - Ashley Sanders On March 6, 2015, 5:27

[asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24807

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/#review14619 --- /branches/13/include/asterisk/utils.h

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/#review14618 --- /branches/13/main/config.c

Re: [asterisk-dev] ARI - Add Support for custom SIP Headers with Originate

2015-03-09 Thread Nir Simionovich
Cool, too bad it isn't documented. I'll add it into PHPARI as well. On Mar 8, 2015 6:18 PM, Matthew Jordan mjor...@digium.com wrote: On Sun, Mar 8, 2015 at 10:51 AM, Nir Simionovich nir.simionov...@gmail.com wrote: Ok, I'll have a look into that one. On Sun, Mar 8, 2015 at 1:03 PM, Olle

Re: [asterisk-dev] ARI - Add Support for custom SIP Headers with Originate

2015-03-09 Thread Olle E. Johansson
On 09 Mar 2015, at 08:54, Nir Simionovich nir.simionov...@gmail.com wrote: Cool, too bad it isn't documented. I'll add it into PHPARI as well. I believe that this was one of the reasons we created the support for _VARIABLE and __VARIABLE in Asterisk. The ability to reach over to the new

Re: [asterisk-dev] ARI - Add Support for custom SIP Headers with Originate

2015-03-09 Thread Olle E. Johansson
On 08 Mar 2015, at 17:17, Matthew Jordan mjor...@digium.com wrote: You should be able to do it with just the channel variable SIPADDHEADER, that is: SIPADDHEADER=X-CustomHeader-1: foo SIPADDHEADER=X-CustomHeader-2: bar I think there's a serial number in the name of the variable. /O--