[asterisk-dev] [Code Review] 4189: chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4189/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 8:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/#review14690 --- Ship it! Ship It! - gareth On March 13, 2015, 5:13 p.m., rm

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/#review14688 --- /branches/13/configs/basic-pbx/extensions.conf

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

Re: [asterisk-dev] [Code Review] 4489: res_pjsip: allow configuration of endpoint identifier query order

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4489/#review14685 --- Ship it! Ship It! branches/13/include/asterisk/res_pjsip.h <

Re: [asterisk-dev] [Code Review] 4391: Add blank line between headers and output for Command action response

> On Jan. 29, 2015, 8:22 p.m., George Joseph wrote: > > If you run the Testsuite, you'll get a good indication of whether this is > > truly backwards compatible. > > gareth wrote: > I ran the test apps/queue/set_penalty which makes use of ami.command and > it failed. > > However t

Re: [asterisk-dev] [Code Review] 4478: testsuite: Fix reference leaks and shutdown timeouts in more tests

> On March 12, 2015, 2:11 p.m., Mark Michelson wrote: > > Regarding the remaining leak on the local optimize away test, if you do > > find that it is a leak in Asterisk, please file an issue for it. ASTERISK-24876 created. - Corey ---

Re: [asterisk-dev] [Code Review] 4478: testsuite: Fix reference leaks and shutdown timeouts in more tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4478/ --- (Updated March 13, 2015, 12:30 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

> On March 12, 2015, 3:41 p.m., Matt Jordan wrote: > > 1. For this to go into Asterisk 13, tests will need to be provided that > > cover the new parameter. (Really, those tests should be written regardless) > > 2. The CHANGES file will need to get updated with the new option. > > rmudgett wrote

[asterisk-dev] [Code Review] 4489: res_pjsip: allow configuration of endpoint identifier query order

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4489/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24840 https://i

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add "rpid_immediate" option to prevent unnecessary "180 Ringing" messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- (Updated March 13, 2015, 12:13 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4487: AMI PJSIPShowEndpoint closes AMI connection on error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4487/ --- (Updated March 13, 2015, 12:05 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4472: chan_pjsip/res_pjsip_callerid: Make Party ID handling simpler and consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4472/ --- (Updated March 13, 2015, 11:26 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471/#review14680 --- These tests don't currently release their reference to the recu

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471/#review14681 --- Ship it! Besides the memory leak I accidentally gave you these

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- (Updated March 13, 2015, 4:04 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4462: DNS core unit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4462/#review14679 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 9:02 p.m.

Re: [asterisk-dev] [Code Review] 4484: testsuite: Fix HEP tests that fail after fixing pjsip.conf type=global default application.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4484/ --- (Updated March 13, 2015, 10:57 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4470/ --- (Updated March 13, 2015, 10:43 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4487: AMI PJSIPShowEndpoint closes AMI connection on error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4487/#review14678 --- Ship it! Ship It! - rmudgett On March 13, 2015, 2:28 a.m.,

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

> On March 11, 2015, 6:05 p.m., rmudgett wrote: > > /trunk/include/asterisk/dns_recurring.h, line 48 > > > > > > Since DNS resolution can take time, should the next refresh interval be > > set in advance of the lowe

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/#review14676 --- /branches/13/configs/basic-pbx/extensions.conf

[asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

> On March 10, 2015, 1:26 p.m., Ed Hynan wrote: > > /trunk/res/res_timing_kqueue.c, line 240 > > > > > > Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on > > all kqueue(2) systems. > > Justin

[asterisk-dev] [Code Review] 4487: AMI PJSIPShowEndpoint closes AMI connection on error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4487/ --- Review request for Asterisk Developers. Repository: Asterisk Description