Re: [asterisk-dev] [Code Review] 4502: Improved and portable ast_log recursion avoidance

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4502/#review14881 --- Before committing I found a link error for utils/refcounter due

Re: [asterisk-dev] [Code Review] 4502: Improved and portable ast_log recursion avoidance

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4502/ --- (Updated March 27, 2015, 2:06 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, line 977 > > > > > > So, dup'ing things on the stack here in a nested loop is actually quite > > dangerous. Unlike a local varia

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated March 27, 2015, 11:22 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? There can only be one variable size s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, line 977 > > > > > > So, dup'ing things on the stack here in a nested loop is actually quite > > dangerous. Unlike a local varia

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14886 --- /branches/13/main/threadpool.c

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 27, 2015, 11:42 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

> On March 26, 2015, 11:13 p.m., Diederik de Groot wrote: > > /branches/13/channels/pjsip/dialplan_functions.c, line 869 > > > > > > len is of type size_t, which is unsigned. It will not be able to hold a > > value

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/#review14888 --- Just adding a note to the comment. /branches/13/include/aster

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4527/ --- (Updated March 27, 2015, 11:46 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

> On March 26, 2015, 6:52 p.m., Diederik de Groot wrote: > > /branches/13/channels/chan_iax2.c, lines 2026-2032 > > > > > > user_ref function not being used, may/might actually indicate a > > refcount issue. > >

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4527/ --- (Updated March 27, 2015, 11:48 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/ --- (Updated March 27, 2015, 12:02 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4526/ --- (Updated March 27, 2015, 12:09 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

> On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: > > /branches/13/funcs/func_env.c, line 728 > > > > > > Note the double closing parens after the first sizeof, i actually > > finishes the ast_str_append_sub

[asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4537/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4537/ --- (Updated March 27, 2015, 12:24 p.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4539/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4539/ --- (Updated March 27, 2015, 12:41 p.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4540/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4540/ --- (Updated March 27, 2015, 12:51 p.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 4538: Fix link error for utils/aelparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4538/ --- Review request for Asterisk Developers. Repository: Asterisk Description

[asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/ --- (Updated March 27, 2015, 1:13 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4538: Fix link error for utils/aelparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4538/#review14891 --- Ship it! Ship It! - Joshua Colp On March 27, 2015, 11:52 a.

Re: [asterisk-dev] [Code Review] 4538: Fix link error for utils/aelparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4538/ --- (Updated March 27, 2015, 7:25 a.m.) Status -- This change has been ma

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Corey Farrell has uploaded a new change for review. https://gerrit.asterisk.org/15 Change subject: Memory Debugging Improvements .. Memory Debugging Improvements * Enable XML output from valgrind. * Display and save a summary

Re: [asterisk-dev] [Code Review] 4525: clang compiler warning: -Wabsolute-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4525/ --- (Updated March 27, 2015, 1:38 p.m.) Review request for Asterisk Developers

[asterisk-dev] Change in repotools[master]: Add web proxy support to commit_msg.py

Michael L. Young has uploaded a new patch set (#3). Change subject: Add web proxy support to commit_msg.py .. Add web proxy support to commit_msg.py This patch allows the commit_msg.py script to connect to the issue tracker from

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

> On March 26, 2015, 12:37 p.m., Diederik de Groot wrote: > > /branches/13/funcs/func_env.c, line 728 > > > > > > Note the double closing parens after the first sizeof, i actually > > finishes the ast_str_append_su

Re: [asterisk-dev] [Code Review] 4531: clang compiler warning: -Wparentheses-equality

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4531/#review14893 --- Ship it! Ship It! - Matt Jordan On March 26, 2015, 1:20 p.m

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4530/#review14895 --- Ship it! Ship It! - Matt Jordan On March 26, 2015, 1:12 p.m

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/#review14894 --- /branches/13/pbx/pbx_config.c

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4527/#review14896 --- Ship it! Ship It! - Matt Jordan On March 27, 2015, 5:48 a.m

Re: [asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4537/#review14897 --- Ship it! /branches/13/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4539/#review14898 --- Ship it! I think your solution here is fine. - Matt Jordan

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Corey Farrell has uploaded a new patch set (#2). Change subject: Memory Debugging Improvements .. Memory Debugging Improvements * Enable XML output from valgrind. * Display and save a summary of valgrind errors and leaks. * Enab

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

> On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: > > /branches/13/funcs/func_env.c, line 728 > > > > > > Note the double closing parens after the first sizeof, i actually > > finishes the ast_str_append_sub

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled.

Matt Jordan has posted comments on this change. Change subject: PJSIP: Added test to ensure retransmissions are not handled. .. Patch Set 1: (2 comments) https://gerrit.asterisk.org/#/c/14/1//COMMIT_MSG Commit Message: Line 1

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

> On March 23, 2015, 9:57 a.m., Matt Jordan wrote: > > Ship It! As an addendum to this, this patch does not merge cleanly on Asterisk 11. As such, I'll be merging this to Asterisk 13+. Alas, as I don't run a system that can compile kqueue, it's kind of hard for me to backport that. If someone

[asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/ --- (Updated March 27, 2015, 9:41 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated March 27, 2015, 2:45 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 9:54 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

> On March 24, 2015, 1:15 p.m., rmudgett wrote: > > ./branches/13/apps/app_stasis.c, lines 77-79 > > > > > > Using a parameter value before asserting that it is non-NULL is just > > wrong. > > > > That's ju

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 9:59 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 10:01 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/ --- (Updated March 27, 2015, 10:02 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

> On March 24, 2015, 1:15 p.m., Kevin Harwell wrote: > > ./asterisk/trunk/tests/rest_api/applications/stasis_status/ari_client.py, > > lines 351-352 > > > > > > I would opt for the python convention of "easier to a

[asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/#review14902 --- ./asterisk/trunk/tests/rest_api/applications/stasis_status/tes

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543/ --- (Updated March 27, 2015, 4:08 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

> On March 27, 2015, 2:26 p.m., Matt Jordan wrote: > > I think your solution here is fine. Hi Matt, can i commit directly to the svn repository or does someone have to do this for me. Your 'ship it' gives the impression that i can. If so is there a particular format to which the commit message

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/ --- (Updated March 27, 2015, 10:56 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/ --- (Updated March 27, 2015, 10:58 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519/ --- (Updated March 27, 2015, 10:59 a.m.) Review request for Asterisk Developer

[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 26, 2015, 8:11 p.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? > > Diederik de Groot wrote: > Th

[asterisk-dev] [Code Review] 4545: clang compiler warning: -Wunused-command-line-argument

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4545/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 26, 2015, 8:11 p.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? > > Diederik de Groot wrote: > Th

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/#review14906 --- Ship it! Go ahead and ship it after uncommenting that format s

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? > > Diederik de Groot wrote: > Th

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/#review14907 --- /branches/13/formats/format_wav.c

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

> On March 27, 2015, 10:39 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 3325-3328 > > > > > > Just a question - if I somehow have two messages in-flight in > > processing what will happen here?

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

> On March 26, 2015, 6:37 p.m., Diederik de Groot wrote: > > /branches/13/funcs/func_env.c, line 728 > > > > > > Note the double closing parens after the first sizeof, i actually > > finishes the ast_str_append_sub

Re: [asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

> On March 27, 2015, 2:26 p.m., Matt Jordan wrote: > > /branches/13/channels/chan_iax2.c, line 11898 > > > > > > Interestingly enough, we don't use this value anywhere :-P > > > > But that's a different p

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated March 27, 2015, 5:32 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:23 p.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

> On March 27, 2015, 5:20 p.m., Jared Smith wrote: > > /branches/13/formats/format_wav.c, line 67 > > > > > > Red blob... I like to line up the slashes when using macro's. But ok - Diederik -

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- (Updated March 27, 2015, 5:38 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 26, 2015, 8:11 p.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? > > Diederik de Groot wrote: > Th

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/ --- (Updated March 27, 2015, 4:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/#review14915 --- Ship it! Ship It! - Jonathan Rose On March 27, 2015, 11:39

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 8:23 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/main/stdtime/localtime.c, lines 357-361 > > > > > > Just curious, what was the compiler warning on this one? > > Diederik de Groot wrote: > Th

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4530/ --- (Updated March 27, 2015, 6:10 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/#review14917 --- I'm wondering if -Wself-assign should not be enabled. It appea

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:23 p.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- (Updated March 27, 2015, 6:20 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

> On March 27, 2015, 6:14 p.m., rmudgett wrote: > > I'm wondering if -Wself-assign should not be enabled. It appears to be > > just a nuisance warning. I do agree, some of the clang warnings can be a little bit petty to be honest. Some of them have proven to be quite usefull though. I will le

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

> On March 24, 2015, 11:23 a.m., Matt Jordan wrote: > > ./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py, > > lines 20-26 > > > > > > You may want to consider moving this class back into runte

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled.

Mark Michelson has uploaded a new patch set (#2). Change subject: PJSIP: Added test to ensure retransmissions are not handled. .. PJSIP: Added test to ensure retransmissions are not handled. In this test, a SIPp scenario sends t

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled.

Mark Michelson has uploaded a new patch set (#2). Change subject: PJSIP: Added test to ensure retransmissions are not handled. .. PJSIP: Added test to ensure retransmissions are not handled. In this test, a SIPp scenario sends t

Re: [asterisk-dev] [Code Review] 4523: res_pjsip_registrar_expire.c: Cleanup scheduler leaks on unload/shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4523/ --- (Updated March 27, 2015, 12:51 p.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 4531: clang compiler warning: -Wparentheses-equality

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4531/ --- (Updated March 27, 2015, 6:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4531: clang compiler warning: -Wparentheses-equality

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4531/ --- (Updated March 27, 2015, 6:53 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4546/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

[asterisk-dev] [Code Review] 4547: clang compiler warning: braces-around-scalar-initializer

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4547/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i

[asterisk-dev] Change in testsuite[master]: Testsuite: Test for res_pjsip_config_wizard auto-create hints

George Joseph has uploaded a new patch set (#2). Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints .. Testsuite: Test for res_pjsip_config_wizard auto-create hints This test uses ListDialPlan to che

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

> On March 24, 2015, 1:15 p.m., Kevin Harwell wrote: > > ./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py, > > lines 22-23 > > > > > > A lot of the code in this object as well as others (AriCl

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled ...

Jared K. Smith has uploaded a new patch set (#3). Change subject: PJSIP: Added test to ensure retransmissions are not handled twice. .. PJSIP: Added test to ensure retransmissions are not handled twice. In this test, a SIPp sce

[asterisk-dev] Change in testsuite[master]: Testsuite: Test for res_pjsip_config_wizard auto-create hints

Jared K. Smith has posted comments on this change. Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/10 To unsubscribe, v

Re: [asterisk-dev] [Code Review] 4532: PJSIP: Create transactions for out-of-dialog responses

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4532/ --- (Updated March 27, 2015, 3:34 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

> On March 24, 2015, 1:15 p.m., Kevin Harwell wrote: > > ./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py, > > lines 22-23 > > > > > > A lot of the code in this object as well as others (AriCl

Re: [asterisk-dev] [Code Review] 4524: res_pjsip_registrar_expire.c: Made use ao2 container template routines and eliminated some RAII_VAR() usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4524/ --- (Updated March 27, 2015, 4:04 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4388: Testsuite: Test for res_pjsip_config_wizard auto-create hints.

> On March 25, 2015, 10:24 a.m., Ashley Sanders wrote: > > asterisk/trunk/tests/channels/pjsip/config_wizard/hints/test-config.yaml, > > line 8 > > > > > > This needs to be updated to reflect the version in which the

Re: [asterisk-dev] [Code Review] 4488: Super Awesome Company: Phase 1 - Patch 2 - Outside Connectivity!

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4488/ --- (Updated March 27, 2015, 4:16 p.m.) Status -- This change has been ma

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled ...

Matt Jordan has posted comments on this change. Change subject: PJSIP: Added test to ensure retransmissions are not handled twice. .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/14 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled ...

Matt Jordan has posted comments on this change. Change subject: PJSIP: Added test to ensure retransmissions are not handled twice. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.asterisk.org/14 To unsubscribe, vi

  1   2   >