Re: [asterisk-dev] [Code Review] 4606: chan_sip: make progressinband default to no

2015-04-10 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4606/ --- (Updated April 10, 2015, 4:04 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

2015-04-10 Thread Matt Jordan
On April 10, 2015, 9:50 a.m., Matt Jordan wrote: I'm going to go ahead and post this for review on Gerrit (gerrit.asterisk.org) - particularly since the 'findings' were very minor. That will allow us to go ahead and commit the patch for the auto-dtmf mode ahead of the move to Git

Re: [asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

2015-04-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4609/#review15183 --- Reviewed: I didn't have any findings. - Matt Jordan On

Re: [asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

2015-04-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4609/#review15184 --- Ship it! /branches/13/main/channel.c

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

2015-04-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108/#review15185 --- /trunk/main/astobj2.c

Re: [asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

2015-04-10 Thread rmudgett
On April 10, 2015, 5:15 p.m., Mark Michelson wrote: /branches/13/main/channel.c, lines 4146-4149 https://reviewboard.asterisk.org/r/4609/diff/1/?file=73842#file73842line4146 I figure I should point out why translate_via_slin is on by default. The big reason is for audiohooks or

Re: [asterisk-dev] [Code Review] 4609: chan_pjsip/res_pjsip/bridge_softmix/core: Improve translation path choices.

2015-04-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4609/ --- (Updated April 10, 2015, 11:30 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

2015-04-10 Thread Corey Farrell
On April 10, 2015, 7:05 p.m., rmudgett wrote: /trunk/main/astobj2.c, lines 492-494 https://reviewboard.asterisk.org/r/4108/diff/5-6/?file=71780#file71780line492 The comment doesn't make sense. How is destructor_fn supposed to access values in the weak proxy? The real object is

Re: [asterisk-dev] [Code Review] 4585: res_pjsip: Refactor endpt_send_request to include transaction timeout

2015-04-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4585/ --- (Updated April 10, 2015, 6:34 p.m.) Review request for Asterisk