Re: [asterisk-dev] Review Request: DNS NAPTR/SRV Test plan for PJSIP

2015-04-14 Thread Olle E. Johansson
First quick observation: please don't use .internal. There are domains for example use, like example.com or internal use - and that's .local There are a lot of tests in the SIPit site you can play with to get more inspiration. /O On 13 Apr 2015, at 20:11, Mark Michelson mmichel...@digium.com

[asterisk-dev] Subjects for e-mails

2015-04-14 Thread Olle E. Johansson
Can we possibly have different Subject: lines in e-mails for a commit and for a review. Seems like everything is a change in asterisk now. I would like to be able to prioritize reading the commits. THanks, /O Begin forwarded message: From: Matt Jordan (Code Review) asteriskt...@digium.com

Re: [asterisk-dev] Asterisk 1.8/12 build system changes

2015-04-14 Thread Russell Bryant
On Tue, Apr 14, 2015 at 1:37 PM, Matthew Jordan mjor...@digium.com wrote: Hello! As you know, 1.8 and 12 are in security fix only mode. Generally, that would normally mean that releases made from those branches would only ever be made from the previous tag, ensuring that the only changes in

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Dan Jenkins
On Tue, Apr 14, 2015 at 3:18 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Apr 14, 2015 at 8:47 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 2:15 AM, Olle E. Johansson o...@edvina.net wrote: Can we possibly have different Subject: lines in e-mails for

Re: [asterisk-dev] Asterisk 1.8/12 build system changes

2015-04-14 Thread George Joseph
On Tue, Apr 14, 2015 at 11:37 AM, Matthew Jordan mjor...@digium.com wrote: Hello! As you know, 1.8 and 12 are in security fix only mode. Generally, that would normally mean that releases made from those branches would only ever be made from the previous tag, ensuring that the only changes in

[asterisk-dev] Asterisk 1.8/12 build system changes

2015-04-14 Thread Matthew Jordan
Hello! As you know, 1.8 and 12 are in security fix only mode. Generally, that would normally mean that releases made from those branches would only ever be made from the previous tag, ensuring that the only changes in the versions are specific to the security issues being resolved. However,

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-14 Thread Matthew Jordan
On Wed, Apr 8, 2015 at 1:03 PM, Mark Michelson reviewbo...@asterisk.org wrote: Before I repost the AstDB Clustering review from Review Board onto Gerrit, I wanted to address Mark's concerns below. Depending on what people think, it may be worth just shelving the idea. The only things I can

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Russell Bryant
On Tue, Apr 14, 2015 at 8:47 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 2:15 AM, Olle E. Johansson o...@edvina.net wrote: Can we possibly have different Subject: lines in e-mails for a commit and for a review. Seems like everything is a change in asterisk now. I

Re: [asterisk-dev] [Code Review] 4612: Command cdr show pgsql status dont work

2015-04-14 Thread Rodrigo Ramirez Norambuena
On April 13, 2015, 11:18 p.m., Matt Jordan wrote: The Asterisk project has migrated to Gerrit. Reviews on Review Board should be moved to Gerrit: https://gerrit.asterisk.org Please see the instructions on using Gerrit here:

Re: [asterisk-dev] Git Migration update

2015-04-14 Thread Russell Bryant
On Mon, Apr 13, 2015 at 6:52 PM, Matthew Jordan mjor...@digium.com wrote: For *right now*, we are going to try cherry-picking the changes to the affected branches when the change is first up for review. This is clearly a pretty big change in process, as the act of merging into other branches

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Matthew Jordan
On Tue, Apr 14, 2015 at 9:43 AM, Dan Jenkins dan.jenkin...@gmail.com wrote: On Tue, Apr 14, 2015 at 3:18 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Apr 14, 2015 at 8:47 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 2:15 AM, Olle E. Johansson

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Russell Bryant
On Tue, Apr 14, 2015 at 10:55 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 9:43 AM, Dan Jenkins dan.jenkin...@gmail.com wrote: On Tue, Apr 14, 2015 at 3:18 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Apr 14, 2015 at 8:47 AM, Matthew Jordan

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Olle E. Johansson
On 14 Apr 2015, at 17:06, Russell Bryant russ...@russellbryant.net wrote: On Tue, Apr 14, 2015 at 10:55 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 14, 2015 at 9:43 AM, Dan Jenkins dan.jenkin...@gmail.com wrote: On Tue, Apr 14, 2015 at 3:18 PM, Russell Bryant

Re: [asterisk-dev] [Code Review] 4580: Fix issue with Makefile that prevents use of ~/.asterisk.makeopts and /etc/asterisk.makeopts

2015-04-14 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4580/ --- (Updated April 14, 2015, 3:48 p.m.) Status -- This change has been

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: python/asterisk/version: Update version handling for Git migration .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/91 To

Re: [asterisk-dev] Subjects for e-mails

2015-04-14 Thread Matthew Jordan
On Tue, Apr 14, 2015 at 2:15 AM, Olle E. Johansson o...@edvina.net wrote: Can we possibly have different Subject: lines in e-mails for a commit and for a review. Seems like everything is a change in asterisk now. I would like to be able to prioritize reading the commits. I took a look at

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: python/asterisk/version: Update version handling for Git migration .. python/asterisk/version: Update version handling for Git migration This patch

[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: python/asterisk/version: Update version handling for Git migration .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/91 To