Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-29 Thread Christopher Wolfe
is overzealous, so the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-08-14 Thread Christopher Wolfe
-CREATION Diff: https://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-08-12 Thread Christopher Wolfe
ictly YAML and ari pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-08-12 Thread Christopher Wolfe
eSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-08-12 Thread Christopher Wolfe
than one test could be run. - All tests are done sequentially (with the first element in the list being triggered first) and not asynchronous, unlike other pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
a channel after playback is done. This is so that the results aren't fudged. It was discovered during testing that muting is overzealous, so the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- __

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/#review12955 --- On July 30, 2014, 4:21 p.m., Christopher Wolfe wrote: > >

[asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-07-30 Thread Christopher Wolfe
zealous, so the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or updat

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-30 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-25 Thread Christopher Wolfe
es in the log files. One bottleneck to finishing this test was the fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-25 Thread Christopher Wolfe
list being triggered first) and not asynchronous, unlike other pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-24 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-24 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-24 Thread Christopher Wolfe
ne test could be run and that things could be run sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options v

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-24 Thread Christopher Wolfe
be run and that things could be run sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-24 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/#review12853 ------- On July 22, 2014, 6:46 p.m., Christopher Wolfe wrote: > >

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-23 Thread Christopher Wolfe
received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-23 Thread Christopher Wolfe
ck to finishing this test was the fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Ch

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-22 Thread Christopher Wolfe
eSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-22 Thread Christopher Wolfe
e fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -

[asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-22 Thread Christopher Wolfe
, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-22 Thread Christopher Wolfe
name, so I left it as was. - Tested the different scenarios of setting the filepath- relative and defined. - Made sure the various tests could fail if a certain sound file didn't meet the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that thi

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-22 Thread Christopher Wolfe
various tests could fail if a certain sound file didn't meet the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that things could be run sequentially. Thanks, Christopher Wolfe --

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-21 Thread Christopher Wolfe
filepath- relative and defined. - Made sure the various tests could fail if a certain sound file didn't meet the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that things could b

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-07-17 Thread Christopher Wolfe
. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-07-15 Thread Christopher Wolfe
order to progress the test. Compared the channels that entered the bridge with one that didn't. Originally had a python code approach, but then used strictly YAML and ari pluggable modules. Thanks, Christo

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-09 Thread Christopher Wolfe
the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that things could be run sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www

[asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-09 Thread Christopher Wolfe
risk/pluggable_modules.py 5168 Diff: https://reviewboard.asterisk.org/r/3733/diff/ Testing --- Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing