Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-14 Thread Ed Hynan
> On March 10, 2015, 1:26 p.m., Ed Hynan wrote: > > /trunk/res/res_timing_kqueue.c, line 240 > > <https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240> > > > > Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on >

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-13 Thread Ed Hynan
> On March 10, 2015, 1:26 p.m., Ed Hynan wrote: > > /trunk/res/res_timing_kqueue.c, line 240 > > <https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240> > > > > Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on >

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-12 Thread Ed Hynan
> On March 10, 2015, 1:26 p.m., Ed Hynan wrote: > > /trunk/res/res_timing_kqueue.c, line 240 > > <https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240> > > > > Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on >

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-11 Thread Ed Hynan
> On March 10, 2015, 1:26 p.m., Ed Hynan wrote: > > /trunk/res/res_timing_kqueue.c, line 240 > > <https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240> > > > > Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on >

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-10 Thread Ed Hynan
-429b-aa0f-873bbd652a6f__patchtest.tgz Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Ed Hynan
.asterisk.org/r/4465/#comment25182> See above. - Ed Hynan On March 9, 2015, 6:21 p.m., Justin T. Gibbs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-06 Thread Ed Hynan
developed test program that can run original or patched 11.7.0 code. File Attachments (updated) Test r3 https://reviewboard.asterisk.org/media/uploaded/files/2015/03/06/a29ea5c5-3253-429b-aa0f-873bbd652a6f__patchtest.tgz Thanks, Ed Hynan

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-03 Thread Ed Hynan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14550 --- - Ed Hynan On March 3, 2015, 3:25 p.m., Ed Hynan wrote

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-03 Thread Ed Hynan
p.m., Matt Jordan wrote: > > tags/11.7.0/main/stdtime/localtime.c, lines 482-484 > > <https://reviewboard.asterisk.org/r/4450/diff/1/?file=71624#file71624line482> > > > > I'm not sure why we are printing out to stderr here, but generally > > Asterisk does

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-03 Thread Ed Hynan
Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-03 Thread Ed Hynan
program https://reviewboard.asterisk.org/media/uploaded/files/2015/02/25/f7a19f2a-4a8a-4aff-b7d6-44a4146c358c__patchtest.tgz Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-02-25 Thread Ed Hynan
gt; remove this section if it isn't useful. OK. That's only there because a look at the manpage made me wonder about it; hope was that persons more familiar with Linux inotify would clear it up. I'll remove it for next patch. - Ed ----

[asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-02-25 Thread Ed Hynan
or patched 11.7.0 code. File Attachments localtime.c (11.7.0) test program https://reviewboard.asterisk.org/media/uploaded/files/2015/02/25/f7a19f2a-4a8a-4aff-b7d6-44a4146c358c__patchtest.tgz Thanks, Ed Hynan