Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

> On March 31, 2015, 11:19 a.m., Michael Young wrote: > > I would hold off on committing this patch as I feel it is not really a > > proper solution. I believe that this is just short circuiting the > > conditional and always applying remapping if IPv6 is involved or no

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

addresses are not being mapped to IPv6 at all according to the debug logs. - Michael Young On March 30, 2015, 10:23 a.m., Valentin Vidić wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3957: Update commit_msg.py To Work With A Web Proxy, Follow New Commit Msg Format, Prompt For License

://reviewboard.asterisk.org/r/3957/diff/ Testing --- Tested from behind a web proxy and on current development machine. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 3957: Update commit_msg.py To Work With A Web Proxy, Follow New Commit Msg Format, Prompt For License

proxy and on current development machine. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

--- This was tested on a test machine. The reporter of the issue also tested this and has confirmed that it solves both issues. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

The reporter of the issue also tested this and has confirmed that it solves both issues. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRI

[asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

resolves these two issues. Diffs - /branches/11/channels/chan_iax2.c 419562 Diff: https://reviewboard.asterisk.org/r/3856/diff/ Testing --- This was tested on a test machine. The reporter of the issue also tested this and has confirmed that it solves both issues. Thanks, Michael

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

on tracing in order to see this problem and also to confirm that this patch was functioning again as expected. I ran the testsuite test that was failing before the patch and then after the patch to confirm that the test no passes as well. Thanks, Michael Young

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

confirm that this patch was functioning again as expected. I ran the testsuite test that was failing before the patch and then after the patch to confirm that the test no passes as well. Thanks, Michael Young -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3841/#review12851 --- On July 23, 2014, 1:21 p.m., Michael Young wrote: > > --- >

Re: [asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

--- On July 23, 2014, 1:21 p.m., Michael Young wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3841/ > -

[asterisk-dev] [Code Review] 3841: Fix Regression From AstDB I/O Performance Improvement Patch

was failing before the patch and then after the patch to confirm that the test no passes as well. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

on dev machine. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

Asterisk 11 box for quite some time. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

/ Testing --- Local pbx with a couple of peers. Did see a slight I/O increase. before patch Re-Register Avg. 404 ms Register Avg. 442 ms after patch Re-Register Avg. 361.5 ms Register Avg. 419 ms Thanks, Michael Young

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

on dev machine. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

atically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/#review12701 ------- On July 16, 2014, 7:53 p.m., Michael Young wrote: > > --- > This is an aut

Re: [asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

Diff: https://reviewboard.asterisk.org/r/3815/diff/ Testing --- Local pbx with a couple of peers. Did see a slight I/O increase. before patch Re-Register Avg. 404 ms Register Avg. 442 ms after patch Re-Register Avg. 361.5 ms Register Avg. 419 ms Thanks, Michael Young

Re: [asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

a beep when MixMonitor starts and an option to play a beep when MixMonitor ends. Diffs - /trunk/apps/app_mixmonitor.c 418785 Diff: https://reviewboard.asterisk.org/r/3820/diff/ Testing --- This patch has been in use on an Asterisk 11 box for quite some time. Thanks, Michael

[asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

://reviewboard.asterisk.org/r/3820/diff/ Testing --- This patch has been in use on an Asterisk 11 box for quite some time. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

/diff/ Testing --- This has been in production since 1.4 and updated for trunk. The trunk version of the patch was tested on dev machine. Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] [Code Review] 3815: Improve AstDb I/O When Updating Rows

after patch Re-Register Avg. 361.5 ms Register Avg. 419 ms Thanks, Michael Young -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 3538: Partial fix to voicemail number maxmsg being overwritten.

> On May 14, 2014, 10:49 p.m., Matt Jordan wrote: > > /trunk/apps/app_voicemail.c, lines 4458-4463 > > > > > > This change avoids the problem you've discovered by completely > > discarding the maxmsg limit set for

Re: [asterisk-dev] [Code Review] 3464: Sounds: Various new sound sets were missing from the makefile and menuselect options

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3464/#review11683 --- Ship it! Ship It! - Michael Young On April 17, 2014, 7:18

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

- /branches/11/funcs/func_audiohookinherit.c 409050 Diff: https://reviewboard.asterisk.org/r/3272/diff/ Testing --- Reporter has tested the patch with successful results. Thanks, Michael Young -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3282/#review11021 --- Ship it! Ship It! - Michael Young On March 2, 2014, 3:45

Re: [asterisk-dev] [Code Review] 3282: Fix a refcount error with realtime MOH

because the testers were still reporting a problem. Is the crash similar to what the reporters on that issue have been reporting? Thanks - Michael Young On March 2, 2014, 3:45 p.m., Russell Bryant wrote: > > --- > This is an auto

[asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

channel. Diffs (updated) - /branches/11/funcs/func_audiohookinherit.c 409050 Diff: https://reviewboard.asterisk.org/r/3272/diff/ Testing (updated) --- Reporter has tested the patch with successful results. Thanks, Michael Young

Re: [asterisk-dev] [Code Review] 2990: Documentation: Clarify "x" Option In chan_spy

arely used option we are opting for a documentation change here. This patch helps to clarify the documentation. Diffs - /branches/1.8/apps/app_chanspy.c 402263 Diff: https://reviewboard.asterisk.org/r/2990/diff/ Testing --- Thanks, Mic