Re: [asterisk-dev] Opus codec Development

2019-06-25 Thread Tzafrir Cohen
Hi all, On 25/06/2019 13:47, Joshua C. Colp wrote: > On Tue, Jun 25, 2019, at 7:44 AM, Mohit Dhiman wrote: >> Hi, >> Can anybody please share what is the development process of opus codec >> in Asterisk? >> Does Asterisk uses the fork from official xiph opus repository for >> development process

[asterisk-dev] Fwd: Bug#925760: libss7: ftbfs with GCC-9

2019-03-29 Thread Tzafrir Cohen
Hi, I wanted to report this as a bug on the libss7 component, but I failed to do so: there are no versions there and thus I can't set a version. Basically it seems gcc does not like strncpy with size same as the buffer size, as in case the source is not null-terminated, the target won't be. -

[asterisk-dev] dahdi_span_assignments fails because of missing "spantypes"

2019-03-13 Thread Tzafrir Cohen
Hi, It seems that a relatively recent change in DAHDI-linux (Was this change made by me? maybe) broke the userspace interface a bit: as of kernel 4.13 the dahdi device has the attibute "dahdi_spantypes" instead of "spantypes". https://issues.

Re: [asterisk-dev] No tag for 13.24.0?

2018-12-17 Thread Tzafrir Cohen
On 17/12/2018 11:52, Niklas Larsson wrote: Hi, I can't find tags for release versions, only the rc - snipped from git tag: 13.20.0-rc1 13.20.0-rc2 13.21.0 13.21.0-rc1 13.

[asterisk-dev] review: dahdi_span_assignments compare

2018-05-07 Thread Tzafrir Cohen
The following patch to dahdi-tools adds the 'compare' subcommand to dahdi_span_assignments, similar to that was earlier added to dahdi_span_types. That is: it will give an output and a non-zero exit value if 'dahdi_span_assignment add' will cause any spans to be assigned. --

[asterisk-dev] [PATCH] dahdi_span_assignments: compare subcommand

2018-05-07 Thread Tzafrir Cohen
dahdi_span_assignments compare, similar to dahdi_span_types compare. Signed-off-by: Tzafrir Cohen --- dahdi_span_assignments | 45 doc/dahdi_span_assignments.8 | 22 +- 2 files changed, 66 insertions(+), 1 deletion(-) diff --git a

Re: [asterisk-dev] Which enviroments are supported, really?

2018-01-22 Thread Tzafrir Cohen
/sh # on that system. The default is dash. -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- a

Re: [asterisk-dev] tags on the main branches [was: Re: Minor Release Branches]

2017-12-26 Thread Tzafrir Cohen
neline --abbrev-commit With this, 'git lol' instead of 'git log' gixes you a commits graph with all the branch heads and tags visible. -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- ___

Re: [asterisk-dev] dahdi dynamic spans and auto-assignment: mostly success

2017-12-26 Thread Tzafrir Cohen
On Mon, Apr 25, 2016 at 04:53:22PM +0300, Tzafrir Cohen wrote: > Hi, > > I wanted to play with local (dynamic) dahdi spans. Therefore I wanted to > figure out how they work with span auto-assignment. It turned out that > reasonably well. > > For starters: move the dynam

Re: [asterisk-dev] tags on the main branches [was: Re: Minor Release Branches]

2017-12-24 Thread Tzafrir Cohen
o be > > completed first? It's basically the same. Effectively a tag at the split point. -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ --

Re: [asterisk-dev] reproducible builds of asterisk

2017-12-20 Thread Tzafrir Cohen
On Wed, Dec 20, 2017 at 01:55:31PM -0600, Matt Fredrickson wrote: > Hey Tzafrir, > > On Wed, Dec 20, 2017 at 3:53 AM, Tzafrir Cohen > wrote: > > Hi, > > > > There is a patch in the Debian package to build Asterisk in a > > reproducible way[1] if so needed.

Re: [asterisk-dev] tags on the main branches [was: Re: Minor Release Branches]

2017-12-20 Thread Tzafrir Cohen
On Wed, Dec 20, 2017 at 07:50:03AM -0700, George Joseph wrote: > On Wed, Dec 20, 2017 at 2:44 AM, Tzafrir Cohen > wrote: > > > Off-topic: > > > > On Tue, Dec 19, 2017 at 01:50:03PM -0700, George Joseph wrote: > > > > > Thankfully we tag EVERYTH

[asterisk-dev] reproducible builds of asterisk

2017-12-20 Thread Tzafrir Cohen
use cases for a reprodicible build of Asterisk. [1] https://reproducible-builds.org/ -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ -- Bandwidth and Colocation P

[asterisk-dev] tags on the main branches [was: Re: Minor Release Branches]

2017-12-20 Thread Tzafrir Cohen
f the git branch in the version string is always "master". We tag everything. But only well after it was branched from the main branch. -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...

[asterisk-dev] [PATCH 2/2] Avoid a race between /etc/init.d/dahdi and hotplug scripts:

2017-08-31 Thread Tzafrir Cohen
From: Oron Peled * On some systems/configurations, dahdi init script may kick in during the time that hotplug scripts are configuring spans. * It may lead to a race since the init script runs "dahdi_auto_assign_compat" which calls "dahdi_registration" and that tries to run "dahdi_span_assi

[asterisk-dev] [PATCH 1/2] dahdi_span_assignments: matched and unmatched

2017-08-31 Thread Tzafrir Cohen
From: Oron Peled Add two new subcommands to dahdi_span_assignments: * matched: list all spans that are in devices that have been registered and are matched by span_assignments.conf lines. * unmatched: list all such existing spans that have not been matched by span_assignments.conf lines. ---

[asterisk-dev] fix for DAHTOOL-78: race: both init script and hotplug may configure astribanks at boot time

2017-08-31 Thread Tzafrir Cohen
The following two patches (The first adds a helper functoinality and the second includes the fix) fix a race in case a system uses hot-pluggable DAHDI and yet includes the iinit script. IIt doesn't cover some edge cases, but those are much less interesting (systems where not all the spans are conf

[asterisk-dev] [PATCH] fail non-blocking I/O in case of span unassignment

2017-06-20 Thread Tzafrir Cohen
In case a user has a file descriptor that is used for non-blocking I/O and the span to which it belongs gets unassigned, its reads and writes will still yield -EAGAIN. This commit adds a test for such a case and returns the proper -ENODEV. Signed-off-by: Tzafrir Cohen --- drivers/dahdi/dahdi

[asterisk-dev] Review: DAHDI: fail non-blocking I/O in case of span unassignment

2017-06-20 Thread Tzafrir Cohen
The MCF/R2 in Asterisk's chan_dahdi is an example of a program that uses non-blocking I/O with DAHDI. If you unassign a span that is used for MFC/R2 with Asterisk, you start getting an endless loop of EAGAIN errors. This is because in case of a non-blocking I/O read that has nothing to return, ther

[asterisk-dev] [PATCH] dahdi_span_types: compare

2017-06-13 Thread Tzafrir Cohen
This adds an extra subcommand: compare: shows span that have been configured (in /etc/dahdi/span_types.conf) to a different value than the one currently active on the system. Signed-off-by: Tzafrir Cohen --- dahdi-bash-completion | 4 ++-- dahdi_span_types | 33

[asterisk-dev] [PATCH] dahdi-tools: add command 'compare' to dahdi_span_types

2017-06-13 Thread Tzafrir Cohen
Applying /etc/dahdi/span_types.conf with 'dahdi_span_types set' requires the spans not to be assigned. In my application I needed to apply a configuration that may include changes to span_types.conf (but normally doesn't). If I do need to apply changes, I need to unassign the spans before doing so,

Re: [asterisk-dev] C++ Asterisk Module

2017-04-06 Thread Tzafrir Cohen
is in the tree (though disabled by default). Asterisk 11 had channels/chan_h323.c that was C, but interfaced with C++ code under channels/h323/ . -- Tzafrir Cohen +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorc

[asterisk-dev] [PATCH] xpp: prevent dracut from loading Astribank drivers

2017-03-22 Thread Tzafrir Cohen
Prevent an early load of the Astribank (xpp) drivers at initrd time, as they require some files from the root filesystem. This installs a file in the dracut configuration directory that will take effect the next time dracut generates an initrd image. --- configure.ac | 9 + xpp/20-da

[asterisk-dev] dahdi and dracut initramfs

2017-03-22 Thread Tzafrir Cohen
ls. [1] A made up example that may or may not make sense and be supported in dracut. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http:/

Re: [asterisk-dev] Line length restrictions in code changes

2017-03-16 Thread Tzafrir Cohen
mp;& do_something_to_it(a_good_variable_name->another_good_name)) { // Do things } -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _

[asterisk-dev] G.729 licensing

2017-01-31 Thread Tzafrir Cohen
It seems that the license of the patents in the G.729 patent pool has expired: http://www.sipro.com/G729.html Are there still pending issues? Will a patch to add a G.729 codec be considered? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50

Re: [asterisk-dev] review: remove support for named channels from chan_dahdi

2016-10-26 Thread Tzafrir Cohen
hat feature had any use I would call to deprecate it first. But I'm not aware of any use for it. Anybody mind removing a few lines from chan_dahdi.c ? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...

[asterisk-dev] review: remove support for named channels from chan_dahdi

2016-10-18 Thread Tzafrir Cohen
DAHDI channels by name is not really used by anyone, and therefore should probably be removed. So, has anyone used this feature? Anybody found it useful? [1] https://gerrit.asterisk.org/4156 -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50

Re: [asterisk-dev] Asterisk 14.0.1 Now Available

2016-10-05 Thread Tzafrir Cohen
s don't work well. I personally don't look at Asterisk 14 for now, as it is not LTS. Has anybody updated the version of the patch for 14 and/or master? [1] https://www.opus-codec.org/license/ [2] https://github.com/seanbright/asterisk-opus [3] https://github.com/traud/asterisk-opus [4]

Re: [asterisk-dev] Using command line arguments in other file than asterisk.c

2016-09-14 Thread Tzafrir Cohen
ine arguments generally relate to asterisk.conf options. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- __

[asterisk-dev] SONAME of libtonezone (dahdi-tools)

2016-06-28 Thread Tzafrir Cohen
Hi, See https://issues.asterisk.org/jira/browse/DAHTOOL-74 . Should it be reverted to the value before 2.11? While I'm at it: what would it take to move dahdi-linux and dahdi-tools to Gerrit? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +9

Re: [asterisk-dev] ASTERISK-26145 - Task Process Issues possibly caused by HEP

2016-06-28 Thread Tzafrir Cohen
nflict on a users that don't know what they are doing. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- __

[asterisk-dev] remove dahdi-speed

2016-06-26 Thread Tzafrir Cohen
good for and hence decided it's not worth the very little overhead it adds. Anybody who actually thinks it is useful: have you actually used it? Why are you sure it does what it is supposed to do (and what is it, exactly)? -- Tzafrir Cohen icq#16849755 jabber:tzafr

Re: [asterisk-dev] BuildSystem: make --jobs without amount of thread hangs

2016-06-09 Thread Tzafrir Cohen
. IIRC this is commonly used by packagers. But I may be wrong. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com --

Re: [asterisk-dev] BuildSystem: make --jobs without amount of thread hangs

2016-06-09 Thread Tzafrir Cohen
issue with make calling itself recursively endlessly and thus creating a mini-ofrk bomb? This should be easy to tell from a look at the process tree (ps fax or whatever) at the time of such a "build", assuming you can run it. -- Tzafrir Cohen icq#16849755

Re: [asterisk-dev] JIRA 25988: Systemd unit file for Asterisk: Submission

2016-05-18 Thread Tzafrir Cohen
ould include a tmpfiles file as well. > ExecStart=/usr/sbin/asterisk -f -C /etc/asterisk/asterisk.conf > ExecStop=/usr/sbin/asterisk -rx 'core stop now' > ExecReload=/usr/sbin/asterisk -rx 'core reload' > Restart=always Check how this interacts with "asterisk

Re: [asterisk-dev] JIRA 25988: Systemd unit file for Asterisk: Submission

2016-05-16 Thread Tzafrir Cohen
md will run the ExecStop command and after it returns will kill all the processes remaining in the control group. Hence merely running 'core stop ' is useless, as systemd will kill it now. In fact, without a wrapper, such an ExecStop command is probably useless with asterisk. --

Re: [asterisk-dev] [asterisk-users] Ubuntu 14 Warning

2016-05-03 Thread Tzafrir Cohen
nd this, you can either > run "apt-get update" and "apt-get upgrade" manually, or run "apt-get > install libsnmp-dev" manually and say "no" to the first solution and "yes" > to the second. Then run install_prereq. Could you please provide

[asterisk-dev] dahdi dynamic spans and auto-assignment: mostly success

2016-04-25 Thread Tzafrir Cohen
1:2:32 # (Nothing special in the rest of the configuration files) -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com h

Re: [asterisk-dev] Attn: pjproject packagers

2016-02-28 Thread Tzafrir Cohen
> for server use instead of it's intended client app use? Can you please give an example of the changes required? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _

Re: [asterisk-dev] Sending digits directly to Asterisk using DAHDI during ramal dialing

2016-02-03 Thread Tzafrir Cohen
s of NNN way larger than 10 if you have a misconfigured phone/line (or badly-written driver). Reporting DTMF up and DTMF down is left for various drivers to implement, if they choose to. As you can see, there are currently two drivers that may send those events. See also DAHDI_TONEDETE

Re: [asterisk-dev] Proposal to bring pjproject back into the fold

2016-01-20 Thread Tzafrir Cohen
see the extra dependencies, and I tried to do something about them (remove unused libraries). Off-topic: is there any point in providing the pjsua (the terminal-based example client) in a separate binary package from the pjproject source package? Is it useful enough fo

Re: [asterisk-dev] Transcoding: Codec 2, iLBC 20, SILK, GSM-EFR, AMR(-WB)

2015-12-08 Thread Tzafrir Cohen
0bps. I read it is used at even lower rates. If I get a "codec2" stream, which rate (and/or other parameters) are used? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-5

Re: [asterisk-dev] Asterisk Docker Containers: Phase 1

2015-11-26 Thread Tzafrir Cohen
m/asterisk.git Includes the Opus codec patch (thanks for all those who keep help maintain it). -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- __

[asterisk-dev] dahdi modules (un)loading and systemd

2015-11-07 Thread Tzafrir Cohen
es the module loading and unloading bits from the init.d script. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _

Re: [asterisk-dev] asterisk rpm package: asterisk-config

2015-06-17 Thread Tzafrir Cohen
Hi, On Tue, Jun 16, 2015 at 11:06:02AM +0300, Tzafrir Cohen wrote: > Hi, > > I'd like to get some feedback on the following: > > In the packaging of asterisk, I'd like to be able to provide an > alternative set of asterisk configuration files as an rpm package.

[asterisk-dev] asterisk rpm package: asterisk-config

2015-06-16 Thread Tzafrir Cohen
age config Conflicts: asterisk < %{version}, asterisk > %{version} another-asteris-config.spec: Provides: asterisk-config Any thoughts? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom

[asterisk-dev] automake support in dahdi-tools

2015-05-19 Thread Tzafrir Cohen
to remove dahdi_speed. It has been there for quite some time and I don't remember anybody asking for it. Could it be removed? Or at least: not installed by default? * Add an option to set the perl directory to the vendorlib (again, a pending Debian patch). I'd like to commit this pa

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-13 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 01:24:17PM -0500, Scott Griepentrog wrote: > > On Tue, May 12, 2015 at 12:59 PM, Tzafrir Cohen > wrote: > > > Quoting the spec: > > > > | Spoofing > > | > > | In order to limit spoofing, the server will return a token for al

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
n any event, why would anybody want to spoof that (as opposed to merely add records to skew the stats, which is possible either way just as easily). What am I missing here? [1] https://packages.debian.org/sid/popularity-contest -- Tzafrir Cohen icq#16849755 jabber:tz

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
d resets counters. Setting up a cron job is simple. And this removes complexity from the Asterisk process. It also removes unnecessary network connectivity from the Asterisk process, and simplifies settings of whatever network settings. -- Tzafrir Cohen icq#16849755

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 10:39:04AM -0600, George Joseph wrote: > On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie wrote: > > > On Tue, May 12, 2015 at 9:47 AM, George Joseph > > wrote: > > > On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen > > > > > wrote

Re: [asterisk-dev] Journald support for Asterisk

2015-05-12 Thread Tzafrir Cohen
tead of to have a String, you have a Dict of Strings. That's nice in theory. Could you please give an example of the required output? An example of how it would help? -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tz

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
r doesn't > kill the main process. > > KISS! This makes it part of the asterisk service, as far as systemd is concerned. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.co

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Tzafrir Cohen
ld be much better. IMHO, the real problem is with the sending part, not with the collecting part. If you don't trust asterisk, don't run it. So how about a module that collects data and, on request, dumps it for sending? This will be done by a simple cron job (asterisk -rx; wget) that is s

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Tzafrir Cohen
d to the distribution. People may also run custom kernels with standard distribution packages. lsb_release --all here gives me: No LSB modules are available. Distributor ID: Debian Description:Debian GNU/Linux 8.0 (jessie) Release:8.0 Codename: jessie -- Tzafrir C

Re: [asterisk-dev] systemd sd_notify() [was: Re: Journald support for Asterisk]

2015-05-10 Thread Tzafrir Cohen
On Sun, May 10, 2015 at 11:03:06AM +0300, Tzafrir Cohen wrote: > On Sat, May 09, 2015 at 10:17:24AM +0200, Ludovic Gasc wrote: > > Hi, > > > > Systemd and Journald is now by default on Debian Jessie and Ubuntu 15.04, > > as on RHEL/CentOS. > > Journald support

[asterisk-dev] systemd sd_notify() [was: Re: Journald support for Asterisk]

2015-05-10 Thread Tzafrir Cohen
. Is this information useful to anything else besides notifying systemd via sd_notify()? [1] http://www.freedesktop.org/software/systemd/man/sd_notify.html [2] Bad name, I know. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

2015-04-12 Thread Tzafrir Cohen (Code Review)
Tzafrir Cohen has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Why is it not included in the main .ignore? main/editline/Makefile etc. -- To view, visit https

Re: [asterisk-dev] [Code Review] 4547: clang compiler warning: braces-around-scalar-initializer

2015-03-29 Thread Tzafrir Cohen
t; little by reordering the fields to improve packing, as in: Just note that such changes break the binary ABI. That is, code built using the old header and code built using the new headers must not be mixed. So this should not be done on a stable version. -- Tzafrir Cohen

[asterisk-dev] CDR: log? lib?

2014-12-31 Thread Tzafrir Cohen
s. I also wonder if they're useful enough to be generated by default (that is: if you can't be bothered to think about rotating them, don't generate them). The same applies to cdr_sqlite, of course. Any thoughts? -- Tzafrir Cohen icq#16849755

Re: [asterisk-dev] git migration update

2014-12-22 Thread Tzafrir Cohen
f I want to work on someone else's branch I can do this sync on my own. I don't think I'd want automerge. Autorebase is probably bad as you can't clone that branch. If I rebase a branch I'd like to decide when it is done. -- Tzafrir Cohen icq#16849755

Re: [asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-31 Thread Tzafrir Cohen
CH), linux-gnu uclinux linux-uclibc kfreebsd-gnu),) Diffs - /branches/13/Makefile 426754 Diff: https://reviewboard.asterisk.org/r/4118/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation P

Re: [asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-30 Thread Tzafrir Cohen
c kfreebsd-gnu),) Diffs (updated) - /branches/13/Makefile 426754 Diff: https://reviewboard.asterisk.org/r/4118/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4117: Fix building chan_phone on big endian systems

2014-10-29 Thread Tzafrir Cohen
endian platforms (sparc, powerpc, s390x) on buildd.debian.org now build. Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 4118: install init.d files on GNU/kFreeBSD

2014-10-28 Thread Tzafrir Cohen
/4118/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailma

[asterisk-dev] [Code Review] 4117: Fix building chan_phone on big endian systems

2014-10-28 Thread Tzafrir Cohen
. Fix those as well? Diffs - /branches/13/channels/chan_phone.c 426440 Diff: https://reviewboard.asterisk.org/r/4117/diff/ Testing --- Big endian platforms (sparc, powerpc, s390x) on buildd.debian.org now build. Thanks, Tzafrir Cohen

Re: [asterisk-dev] Changing hard coded TEST_RESULTS variable in testsuite

2014-10-23 Thread Tzafrir Cohen
u also need to redirect the logs directory (as mentioned there). -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- __

Re: [asterisk-dev] [Code Review] 2783: Fix SIP/TLS reading - random connection drop

2014-10-13 Thread Tzafrir Cohen
roblem (see my comment at the end). The patch I used is by Filip Jenicek. See the bug report for the full log. Diffs - /trunk/main/tcptls.c 397346 Diff: https://reviewboard.asterisk.org/r/2783/diff/ Testing --- Work on trunk

Re: [asterisk-dev] asterisk-testsuite: linux-only

2014-10-13 Thread Tzafrir Cohen
On Mon, Oct 13, 2014 at 09:18:10AM -0400, Russell Bryant wrote: > On Mon, Oct 13, 2014 at 1:58 AM, Tzafrir Cohen > wrote: > > > Hi > > > > I finally got the asterisk-testsuite accpted into Debian (I know, I need > > to get it updated). > > > > A re

[asterisk-dev] asterisk-testsuite: linux-only

2014-10-12 Thread Tzafrir Cohen
;t run Lua tests (is it used for Python ones as well?) -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- _ --

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Tzafrir Cohen
il/asterisk-dev/2014-September/070114.html - Tzafrir Cohen On Sept. 3, 2014, 1:57 p.m., David Lee wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -n (--dry-run)

2014-08-28 Thread Tzafrir Cohen
/runtests.py 5520 Diff: https://reviewboard.asterisk.org/r/3931/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -n (--dry-run)

2014-08-28 Thread Tzafrir Cohen
them. Diffs - /asterisk/trunk/runtests.py 5520 Diff: https://reviewboard.asterisk.org/r/3931/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-28 Thread Tzafrir Cohen
https://reviewboard.asterisk.org/r/3931/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit:

[asterisk-dev] [Code Review] 3949: a separate output-dir option

2014-08-26 Thread Tzafrir Cohen
ent path under /tmp. I really hope noone shouts at me for that. Diffs - /asterisk/trunk/runtests.py 5520 Diff: https://reviewboard.asterisk.org/r/3949/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwi

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-26 Thread Tzafrir Cohen
://reviewboard.asterisk.org/r/3931/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-26 Thread Tzafrir Cohen
run is to run the tests. - Tzafrir --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13170 --- On Aug. 24,

[asterisk-dev] [Code Review] 3932: runtests.py: -H (--hide-skipped)

2014-08-24 Thread Tzafrir Cohen
Description --- Adds an option to runtest.py to to hide skipped tests. Reduces output, but currently formatting could be improved. Diffs - /asterisk/trunk/runtests.py 5520 Diff: https://reviewboard.asterisk.org/r/3932/diff/ Testing --- Thanks, Tzafrir Cohen

[asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-24 Thread Tzafrir Cohen
Description --- Adds option -d (--dry-run) to runtests.py to just list the tests that will be run and not actually run them. Diffs - /asterisk/trunk/runtests.py 5520 Diff: https://reviewboard.asterisk.org/r/3931/diff/ Testing --- Thanks, Tzafrir Cohen

Re: [asterisk-dev] Trying Load a module in asterisk - fails without any message

2014-08-09 Thread Tzafrir Cohen
s compared to > previous asterisk version ? Nothing specific I can think of. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mailto:tzafrir.co...@xorcom.com http://www.xorcom.com -- __

Re: [asterisk-dev] [Code Review] 3707: asterisk.pc file contains a spacing error in CFlags

2014-07-09 Thread Tzafrir Cohen
On Thu, Jul 03, 2014 at 12:02:35PM -, Diederik de Groot wrote: > Which should have been: > Cflags: -I/usr/include/libxml2 -g3 Off-topic: what is libxml2 needed for? $ ls -F /usr/include/libxml2/ libxml/ $ grep -r libxml include/asterisk* [ Nothing ] -- Tzafrir Coh

Re: [asterisk-dev] [Code Review] 3727: Install dahdi span hook only if relevant

2014-07-08 Thread Tzafrir Cohen
ps://reviewboard.asterisk.org/r/3727/#review12513 ------- On July 8, 2014, 3:37 p.m., Tzafrir Cohen wrote: > > --- > This is an automatically generated e-mail.

[asterisk-dev] [Code Review] 3727: Install dahdi span hook only if relevant

2014-07-08 Thread Tzafrir Cohen
/3727/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] Fwd: [asterisk-commits] tzafrir: trunk r417863 - in /trunk: ./ contrib/scripts/

2014-07-07 Thread Tzafrir Cohen
On Sun, Jul 06, 2014 at 01:07:36PM -0400, Corey Farrell wrote: > I'm fine with not installing unless prefix is /usr, but I also think > disabling chan_dahdi should prevent this from being installed. This is something I would rather not have in the main Makefile. -- Tz

Re: [asterisk-dev] Fwd: [asterisk-commits] tzafrir: trunk r417863 - in /trunk: ./ contrib/scripts/

2014-07-06 Thread Tzafrir Cohen
; should not break non-root builds (./configure > --prefix=${HOME}/somelocaldir). Installing the file to ${prefix}/share/dahdi probably does not make sense, as /usr here is the prefix of DAHDI. So I think that the fix is to only install it if the prefix is /usr . Any better idea? --

Re: [asterisk-dev] [Code Review] 3157: dahdi_span_config_hook: script to automatically register new dahdi channels

2014-07-03 Thread Tzafrir Cohen
ATION /trunk/Makefile 406502 Diff: https://reviewboard.asterisk.org/r/3157/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-23 Thread Tzafrir Cohen
channels/sig_pri.c 416446 /trunk/channels/sig_pri.h 416446 /trunk/channels/chan_dahdi.c 416446 Diff: https://reviewboard.asterisk.org/r/3548/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation P

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-17 Thread Tzafrir Cohen
els/sig_pri.c 416446 /trunk/channels/sig_pri.h 416446 /trunk/channels/chan_dahdi.c 416446 Diff: https://reviewboard.asterisk.org/r/3548/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocat

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-17 Thread Tzafrir Cohen
ers > > directly. This is why I gave you the way it should be done earlier. > > Tzafrir Cohen wrote: > I explained (and the comment in the code explains) why that does not > work: destruction of the spans should not be done with the list lock held - > this helps trigger a

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-17 Thread Tzafrir Cohen
channels/sig_pri.h 416393 /trunk/channels/chan_dahdi.c 416393 Diff: https://reviewboard.asterisk.org/r/3548/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-17 Thread Tzafrir Cohen
-------- On June 16, 2014, 4:07 p.m., Tzafrir Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3548/ > -

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-16 Thread Tzafrir Cohen
.asterisk.org/r/3548/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.di

Re: [asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-06-16 Thread Tzafrir Cohen
This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3548/#review11962 ------- On May 19, 2014, 2:32 p.m., Tzafrir Cohen wrote: > > ---

[asterisk-dev] [Code Review] 3548: suspended destructions of pri spans following PRI_EVENT_REMOVED

2014-05-19 Thread Tzafrir Cohen
rg/r/3548/diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] Segmentation fault error?

2014-05-15 Thread Tzafrir Cohen
n asterisk as "asterik -cvvv" or with c option only I get > a > "Segmentation faul" error > with c and g option "Segmentation faul (core dump)" error. > > I don't get it? You have a core dump. Where did it crash? -- Tz

Re: [asterisk-dev] [Code Review] 3426: Fix build failure on SmartOS / Illumos / SunOS

2014-04-08 Thread Tzafrir Cohen
ne of the defined() in that line, but: shouldn't this test be done in autoconf? - Tzafrir Cohen On April 8, 2014, 7:31 p.m., Sebastian Wiedenroth wrote: > > --- > This is an automatically generated e-mail. To re

Re: [asterisk-dev] [Code Review] 3280: Makefile: replace -O6 with -O3

2014-03-03 Thread Tzafrir Cohen
diff/ Testing --- Thanks, Tzafrir Cohen -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3280: Makefile: replace -O6 with -O3

2014-02-27 Thread Tzafrir Cohen
extra specific optimization flags. Workaround for "applying" this fix manually: build with OPTIMIZE=-O3 Diffs - /trunk/Makefile.rules 409155 Diff: https://reviewboard.asterisk.org/r/3280/diff/ Testing --- Thanks,

Re: [asterisk-dev] Installing Asterisk in Mac OS X Mavericks

2014-02-27 Thread Tzafrir Cohen
essages there seem to be valid at first glance. Specifically, can we please please please get rid of -O6? That said, you can work around the latter by providing your own CFLAGS. -- Tzafrir Cohen icq#16849755 jabber:tzafrir.co...@xorcom.com +972-50-7952406 mai

  1   2   3   4   >