iff: https://reviewboard.asterisk.org/r/4470/diff/
Testing
---
* Executed each test successfully 50+ times on local system and build agent
where the test would sometimes fail.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http
* Executed each test successfully 50+ times on local system and build agent
where the test would sometimes fail.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev maili
yaml
6506
/asterisk/trunk/lib/python/asterisk/phones.py 6506
Diff: https://reviewboard.asterisk.org/r/4470/diff/
Testing
---
* Executed each test successfully 50+ times on local system and build agent
where the test would sometimes fail.
Thanks,
asterisk.org/r/4452/diff/
Testing
---
* Executed each test successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-
diff/
Testing
---
* Executed each test successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colo
rch 5, 2015, 1:53 p.m., Ashley Sanders wrote:
> > /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, line 140
> > <https://reviewboard.asterisk.org/r/4452/diff/2/?file=71748#file71748line140>
> >
> > Suggestion, you could remove the ua_cfg variable on line 136 and
e code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing li
e code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing li
1>
> >
> > Why "or 0" ? Isn't that a no-op?
Good question. I used 'tests/rest_api/channels/redirect/nominal/run-test' as a
base and I'm not sure why myself. I've removed it though.
- jbigelow
rly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http:
those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided
ARI/AMI events aren't received and
actions don't fire. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as
ded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
b0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
ed up overriding reg_success() in
> > your new pluggable object?
>
> jbigelow wrote:
> If that condition is removed then it will blow up if callback_module &
> callback_method are not defined in YAML and pjsua_mod.PJsua is being used as
> a test module. If it remains with
ecuting as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update opt
t; If this exception occurs, does lock get properly unlocked?
Fixed this by removing the locking :)
Apparently a lock isn't needed when making call. Unless perhaps a callback
isn't passed and then set later using call.set_callback() but that's not the
case here.
> On Feb. 12, 201
e tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
& attended.
* Pylint score of 9.40/10 for phones.py
* See attached test-config.yaml for a demonstration.
File Attachments
Demonstration
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Tha
actions don't fire. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwid
a few ARI/AMI events aren't received and
actions don't fire. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as
ents
Demonstration
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by
tion
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
eviewboard.asterisk.org/r/4408/diff/
Testing
---
* Executed each test in a loop of 100 iterations with no failures.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Co
sions.conf
6226
Diff: https://reviewboard.asterisk.org/r/4330/diff/
Testing
---
* Executed each test in a loop of 100 iterations with no failures.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
___
.
- jbigelow
On Jan. 26, 2015, 2:16 p.m., Jonathan Rose wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asteris
6 6047 kmoore
tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1
D 6226 6047 kmoore
tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf
- jbigelow
---
This i
> On Jan. 13, 2015, 9:48 a.m., jbigelow wrote:
> > * Under 'URI Parsing' it states: "For the purposes of transport selection
> > the transport parameter is examined." I suggest clarifing that the
> > transport parameter being spoke of is the 't
s for a single
endpoint? I also suggest to include configuration of endpoints showing the
'transport' parameter being used for the example.
* I suggest to either add additional examples with TLS transports. One
showing the recommended way to configure endpoints where some use UDP and
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
h
isk/trunk/tests/rest_api/external_interaction/blind_transfer/call_transfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occur
hus I added a note to the CLI usage
about how it will eventually attempt to re-register. So the patch here has my
vote but I can't speak for what was originally intended.
- jbigelow
---
This is an auto
api/external_interaction/blind_transfer/call_transfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occur
ansfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
--
_
--
sions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4291/diff/
Testing
---
* Executed tests multiple times.
* Review logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth an
Executed tests multiple times.
* Review logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
isk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.a
asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/blind_transfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Tha
buffer successfully.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
value just set
> > these as the defaults on the function parameters (similar to what you did
> > on PcapFile _init_).
I thought of doing it that way while writing it but decided not to so that the
defaults are in a single place and to keep things consistent
/lib/python/asterisk/pcap.py 5913
Diff: https://reviewboard.asterisk.org/r/4156/diff/
Testing
---
Used the options to set a lower snaplen and a higher buffer successfully.
Thanks,
jbigelow
--
_
-- Bandwidth and
> On Oct. 29, 2014, 8:49 a.m., jbigelow wrote:
> > I suggest reusing the 'media_encryption' pjsip.conf option with possible
> > values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I
> > sugg
onf option with possible values
of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest
renaming the option to something like 'media_encryption_attempt' or
'media_encryption_t
K-24411 which
constantly failed as expected.
* Ran test several times without work around for ASTERISK-24414 which
frequently failed as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digita
d.
Diffs
-
/asterisk/trunk/runtests.py 5766
/asterisk/trunk/lib/python/asterisk/test_config.py 5766
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly work a
> On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote:
> > /asterisk/trunk/runtests.py, line 75
> > <https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75>
> >
> > This should include a + "\n" like line 59 does.
>
>
/asterisk/trunk/lib/python/asterisk/test_config.py 5766
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly work as expected now.
Thanks,
jbigelow
--
__
ode and not self.test_config.expect_pass))
> >
> > This will evaluate self.passed to a boolean still.
>
> jbigelow wrote:
> test_runner.py returns 0 if passed and 1 if failed. So the above
> suggestion would need to be like so:
>
> self.passed = (
fore marked
as failed.
Diffs (updated)
-
/asterisk/trunk/runtests.py 5726
/asterisk/trunk/lib/python/asterisk/test_config.py 5726
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly w
newline to visually separate the test that was run from the
tests output. Line 67 doesn't add a new line to the tests output and I don't
believe I should just for this message that I'm appending to the output either.
- jbigelow
---
or expect_pass in (True, False):
... ((not returncode and expect_pass) or (returncode and not
expect_pass))
...
True
0
False
True
Example of explicitly testing for 0 and not 0 as posted for review:
>>> for returncode in (0, 1):
... for expect_pass in (True, False):
...
ed)
-
/asterisk/trunk/runtests.py 5726
/asterisk/trunk/lib/python/asterisk/test_config.py 5726
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to prope
asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly work as expected now.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk
ut failure (with patch for Asterisk
applied from ASTERISK-24411 and work around for ASTERISK-24414)
* Ran test several times without patch applied from ASTERISK-24411 which
constantly failed as expected.
* Ran test several times without work around for ASTERISK-24414 which
frequently fail
/blind_transfer/callee_hold/test-config.yaml
<https://reviewboard.asterisk.org/r/3444/#comment21405>
Should be "blind transfers Alice to Charlie".
- jbigelow
On April 14, 2014, 4:17 p.m., Scott Emidy wrote:
>
> ---
>
0+ times to ensure stability.
* Reviewed test suite & Asterisk logs.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
onfigs/ast1/pjsip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3
blame my copy & paste for not automatically making the changes. :)
- jbigelow
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3407/#review11484
--
when dialing charlie to add the Referred-By
header and commented out the header match for the SIPREFERTOHDR channel
variable. This was to mimic a successful pass to validate the test. This was
done for each.
** Executed tests in a loop 50+ times to ensure stability.
* Reviewed test suite & As
or the SIPREFERTOHDR channel
variable. This was to mimic a successful pass to validate the test. This was
done for each.
** Executed tests in a loop 50+ times to ensure stability.
* Reviewed test suite & Asterisk logs.
Thanks,
jbigelow
--
__
Diff: https://reviewboard.asterisk.org/r/3354/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite & Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Coloca
unk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the tests
& Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mai
sip.conf
PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3
ptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf
PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite & Asterisk logs loo
ps://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite & Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by
ast1/pjsip.conf 4799
/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf 4799
Diff: https://reviewboard.asterisk.org/r/3288/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite &am
ast1/pjsip.conf 4799
/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf 4799
Diff: https://reviewboard.asterisk.org/r/3288/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite &am
ing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite & Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing lis
70 matches
Mail list logo
