Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-23 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959/ --- (Updated Nov. 23, 2013, 10:54 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-23 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959/ --- (Updated Nov. 23, 2013, 11:14 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959/#review10256 --- branches/12/include/asterisk/strings.h

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959/#review10267 --- Note that my findings are very minor, and shouldn't hold up

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959/#review10237 --- Ship it! branches/12/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread Joshua Colp
George Joseph wrote: Just FYI... I've got a whole bunch of pjsip cli stuff waiting on this patch to be committed. Any chance of this happening this week? It'll get reviewed today and pending any other findings arising it'll go in shortly. If possible you could just throw your stuff up

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread George Joseph
On Thu, Nov 21, 2013 at 7:25 AM, Joshua Colp jc...@digium.com wrote: George Joseph wrote: Just FYI... I've got a whole bunch of pjsip cli stuff waiting on this patch to be committed. Any chance of this happening this week? It'll get reviewed today and pending any other findings arising