Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-12-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10336 --- Ship it! Ship It! - Joshua Colp On Nov. 26, 2013, 5:07

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/ --- (Updated Dec. 9, 2013, 10:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-26 Thread Matt Jordan
On Nov. 21, 2013, 3:38 p.m., Joshua Colp wrote: I don't see where the user event is actually checked... shouldn't you have specified the requirement of a Yay event in your test-config.yaml? Mark Michelson wrote: Nope, SimpleTestCase determines pass/fail based solely on the number

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-26 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/ --- (Updated Nov. 26, 2013, 5:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10240 --- Ship it! Ship It! - Joshua Colp On Nov. 20, 2013, 9:12

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10236 --- I don't see where the user event is actually checked...

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-21 Thread Mark Michelson
On Nov. 21, 2013, 3:38 p.m., Joshua Colp wrote: I don't see where the user event is actually checked... shouldn't you have specified the requirement of a Yay event in your test-config.yaml? Nope, SimpleTestCase determines pass/fail based solely on the number of UserEvents that are