---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/
---
(Updated Dec. 11, 2013, 1:22 p.m.)
Status
--
This change has been
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
/branches/12/channels/pjsip/dialplan_functions.c, lines 316-327
https://reviewboard.asterisk.org/r/3038/diff/1/?file=48949#file48949line316
These descriptions are inaccurate when used on outgoing channels.
Matt Jordan wrote:
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
/branches/12/channels/pjsip/dialplan_functions.c, lines 338-345
https://reviewboard.asterisk.org/r/3038/diff/1/?file=48949#file48949line338
These descriptions are inaccurate when used on outbound channels.
Matt Jordan wrote:
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
/branches/12/channels/pjsip/dialplan_functions.c, lines 316-327
https://reviewboard.asterisk.org/r/3038/diff/1/?file=48949#file48949line316
These descriptions are inaccurate when used on outgoing channels.
Matt Jordan wrote:
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
/branches/12/channels/pjsip/dialplan_functions.c, lines 316-327
https://reviewboard.asterisk.org/r/3038/diff/1/?file=48949#file48949line316
These descriptions are inaccurate when used on outgoing channels.
Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/#review10366
---
Ship it!
Heh, looking at the paltry feedback I just provided,
On Dec. 10, 2013, 6:51 p.m., Mark Michelson wrote:
/branches/12/channels/pjsip/dialplan_functions.c, lines 650-652
https://reviewboard.asterisk.org/r/3038/diff/2/?file=49287#file49287line650
It may just be reviewboard, but the second and third lines of this are
indented waaay
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
I have a general thread-safety concern with this addition. In general, the
ast_sip_session, pjsip_dialog, and pjsip_inv_session structures are only
accessed from SIP servant threads. With this set of changes, you access
session data
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/
---
(Updated Dec. 10, 2013, 3:51 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/#review10299
---
I have a general thread-safety concern with this addition. In
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/
---
Review request for Asterisk Developers.
Repository: Asterisk
11 matches
Mail list logo