Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- (Updated Dec. 9, 2013, 4:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10321 --- On the one hand, using AppTest for this set of tests seems

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
On Dec. 6, 2013, 8:45 p.m., Mark Michelson wrote: On the one hand, using AppTest for this set of tests seems like an overly-complicated approach to use, but on the other hand, it works, so it's fine by me. Only reason I'm not putting a Ship it! on this review is that I want to

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- (Updated Dec. 6, 2013, 9:01 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10323 --- Ok, this time it's just reviewboard being stupid. They are

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Jonathan Rose
On Dec. 6, 2013, 9:02 p.m., Jonathan Rose wrote: Ok, this time it's just reviewboard being stupid. They are showing up in the diff file. D configs D configs/ast1 D configs/ast1/extensions.conf D configs/ast1/amd.conf D configs/ast1/iax.conf A

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10326 --- Ship it! Ship It! - Mark Michelson On Dec. 6, 2013, 9:01

[asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-05 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- Review request for Asterisk Developers, Mark Michelson, opticron, and