---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
(Updated Jan. 6, 2014, 11:50 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10518
---
Ship it!
Ship It!
- Mark Michelson
On Dec. 20, 2013, 4:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
(Updated Dec. 19, 2013, 6:49 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10468
---
/trunk/res/res_sorcery_astdb.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10467
---
A few general mentions:
1) I think External should be dropped
On Dec. 10, 2013, 2:20 p.m., Joshua Colp wrote:
/trunk/res/res_sorcery_astdb.c, lines 228-236
https://reviewboard.asterisk.org/r/3061/diff/1/?file=49246#file49246line228
I'll explain why I disagree with this change.
While you gain full regex functionality it comes at a
On Dec. 19, 2013, 11:49 p.m., Mark Michelson wrote:
A few general mentions:
1) I think External should be dropped from all of the MWI action names.
2) I don't see any use for the CLI commands. The whole purpose of external
MWI is that it's being used externally, not by someone with
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
(Updated Dec. 20, 2013, 4:29 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
(Updated Dec. 20, 2013, 4:37 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10383
---
Richard asked me to take a look at this and limit my review to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10351
---
/trunk/res/res_sorcery_astdb.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/#review10358
---
I fundamentally disagree with a design decision made in this
On Dec. 10, 2013, 5:01 p.m., Matt Jordan wrote:
I fundamentally disagree with a design decision made in this patch.
The concept of a 'context' is an Asterisk thing - specifically, a concept
that is derived from static .conf files. It has no semantic meaning outside
of Asterisk, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
Review request for Asterisk Developers.
Repository: Asterisk
14 matches
Mail list logo
