Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-13 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/ --- (Updated Dec. 13, 2013, 12:35 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10407 --- Ship it! Looks good other than the documentation tweak below.

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/ --- (Updated Dec. 12, 2013, 3:03 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread Kevin Harwell
> On Dec. 12, 2013, 9:58 a.m., opticron wrote: > > branches/12/bridges/bridge_native_rtp.c, lines 114-122 > > > > > > This doxygen should get a retval section as well (probably my fault). The return value for this

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-12 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10392 --- branches/12/bridges/bridge_native_rtp.c

Re: [asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/#review10388 --- Ship it! Heh, every time I thought I spotted something wrong,

[asterisk-dev] [Code Review] 3066: bridge_native_rtp: Deadlock during 4-way conference creation

2013-12-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3066/ --- Review request for Asterisk Developers and kmoore. Bugs: ASTERISK-22749