Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
On Dec. 17, 2013, 11:44 p.m., rmudgett wrote: /branches/12/res/res_calendar.c, line 780 https://reviewboard.asterisk.org/r/3067/diff/2-3/?file=49704#file49704line780 Existing bug: chan needs to be locked when adding a datastore. I've fixed this in 1.8 and up since it was applicable

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10450 --- /branches/12/main/core_unreal.c

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10451 --- Ship it! Ship It! - rmudgett On Dec. 18, 2013, 5:31 p.m.,

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- (Updated Dec. 18, 2013, 7:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- (Updated Dec. 17, 2013, 12:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- (Updated Dec. 17, 2013, 11:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-17 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10442 --- /branches/12/res/res_calendar.c

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10430 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/#review10431 --- My only other thought is that we really should limit this

[asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3067/ --- Review request for Asterisk Developers. Repository: Asterisk