Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Jan. 12, 2014, 3:58 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-10 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10564 --- Ship it! I've just looked at the Stasis code, and have no more

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Jan. 9, 2014, 5:34 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
> On Jan. 9, 2014, 4:12 p.m., David Lee wrote: > > /branches/12/main/stasis.c, lines 634-647 > > > > > > I'm curious why you didn't just dispatch_message(sub, message, sync_sub > > == sub); > > > > As it's

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10549 --- /branches/12/main/stasis.c

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10548 --- Ship it! Ship It! - opticron On Jan. 9, 2014, 9:16 a.m., Ma

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10547 --- Ship it! >From a "Does this appear to do the proper thing and

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Jan. 9, 2014, 9:16 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
> On Jan. 8, 2014, 1:56 p.m., opticron wrote: > > /branches/12/main/stasis.c, line 593 > > > > > > When synchronous dispatch is required, why not just dispatch directly > > as if there were no mailbox? It's a good

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10527 --- /branches/12/main/stasis.c

[asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2013-12-31 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- Review request for Asterisk Developers and David Lee. Bugs: ASTERISK-22884