Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated March 11, 2014, 11:06 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On March 10, 2014, 3:38 p.m., opticron wrote: > > This solved the issues I was having when using 0.0.0.0 as the bind address > > for the only defined transport on my multihomed setup. Previously, the > > issue this fixes was causing all kinds of weirdness when trying to connect > > calls and

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review11142 --- Ship it! This solved the issues I was having when using 0.0.0.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review11125 --- Ship it! - Mark Michelson On Feb. 23, 2014, 5:57 p.m., Joshu

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On March 4, 2014, 4:52 p.m., Matt Jordan wrote: > > So, we definitely need to get this in. > > > > Right now, however, I'm struggling with how we can test this. Ideally, we'd > > have some automated test in the Asterisk Test Suite, but besides getting a > > build agent with some special purp

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On March 4, 2014, 10:52 p.m., Matt Jordan wrote: > > So, we definitely need to get this in. > > > > Right now, however, I'm struggling with how we can test this. Ideally, we'd > > have some automated test in the Asterisk Test Suite, but besides getting a > > build agent with some special pur

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On March 4, 2014, 4:52 p.m., Matt Jordan wrote: > > So, we definitely need to get this in. > > > > Right now, however, I'm struggling with how we can test this. Ideally, we'd > > have some automated test in the Asterisk Test Suite, but besides getting a > > build agent with some special purp

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review11060 --- So, we definitely need to get this in. Right now, however, I'm

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated Feb. 23, 2014, 5:57 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10683 --- /branches/12/res/res_pjsip_multihomed.c

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- (Updated Jan. 22, 2014, 3:30 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10655 --- 18<X-Rob> mjordan: if you could update https://reviewboa

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On Jan. 7, 2014, 10:29 a.m., Olle E Johansson wrote: > > Please also check the sender IP address in the IP packet. That's where > > things go wrong with chan_sip. Thanks. > > Matt Jordan wrote: > Olle - just so I understand your comment, are you referring to what would > happen if the se

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On Jan. 9, 2014, 7:19 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_multihomed.c, lines 83-86 > > > > > > If we don't have a multihomed transport and/or the transport hasn't > > changed, I'm not sure why

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

> On Jan. 7, 2014, 3:29 a.m., Olle E Johansson wrote: > > Please also check the sender IP address in the IP packet. That's where > > things go wrong with chan_sip. Thanks. Olle - just so I understand your comment, are you referring to what would happen if the sender was behind a NAT? - Matt

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10540 --- /branches/12/res/res_pjsip_multihomed.c

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/#review10519 --- Please also check the sender IP address in the IP packet. That'

[asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3102/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23020 https://i