Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- (Updated Jan. 14, 2014, 9:32 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10580 --- /branches/11/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-13 Thread Matt Jordan
On Jan. 13, 2014, 3:07 p.m., rmudgett wrote: /branches/11/channels/chan_sip.c, lines 24188-24192 https://reviewboard.asterisk.org/r/3107/diff/2/?file=51266#file51266line24188 You might want to delay setting transferer_pvt to after the call to ast_park_call_exten(). That call can

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- (Updated Jan. 13, 2014, 3:41 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-13 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10584 --- Ship it! Ship It! - Mark Michelson On Jan. 13, 2014, 9:41

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10587 --- /branches/11/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- (Updated Jan. 8, 2014, 5:41 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22834 and

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3107/#review10522 --- The patch is mostly good. One thing that should be done though