Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- (Updated Jan. 14, 2014, 5:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-13 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/#review10585 --- Ship it! Ship It! - Mark Michelson On Jan. 10, 2014, 11:03

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Mark Michelson
On Jan. 10, 2014, 1:38 a.m., Paul Belanger wrote: /branches/12/rest-api/api-docs/mailboxes.json, line 34 https://reviewboard.asterisk.org/r/3117/diff/2/?file=51373#file51373line34 punctuation on the sentence. This isn't a sentence. What punctuation do you expect? - Mark

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Jonathan Rose
On Jan. 9, 2014, 7:38 p.m., Paul Belanger wrote: /branches/12/rest-api/api-docs/mailboxes.json, line 52 https://reviewboard.asterisk.org/r/3117/diff/2/?file=51373#file51373line52 Think it would be good to return the mailbox here, in case the user wanted to confirm the settings.

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Jonathan Rose
On Jan. 9, 2014, 7:38 p.m., Paul Belanger wrote: /branches/12/rest-api/api-docs/mailboxes.json, line 34 https://reviewboard.asterisk.org/r/3117/diff/2/?file=51373#file51373line34 punctuation on the sentence. Mark Michelson wrote: This isn't a sentence. What punctuation do

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/#review10569 --- /branches/12/res/ari/resource_mailboxes.c

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Matt Jordan
On Jan. 9, 2014, 7:38 p.m., Paul Belanger wrote: /branches/12/rest-api/api-docs/mailboxes.json, line 52 https://reviewboard.asterisk.org/r/3117/diff/2/?file=51373#file51373line52 Think it would be good to return the mailbox here, in case the user wanted to confirm the settings.

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- (Updated Jan. 10, 2014, 5:03 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/ --- (Updated Jan. 9, 2014, 5:38 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3117: ARI: mailboxes resource - use external MWI with ARI

2014-01-09 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3117/#review10556 --- /branches/12/rest-api/api-docs/mailboxes.json