Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-24 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- (Updated Jan. 24, 2014, 12:01 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-17 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/#review10624 --- Ship it! Ship It! - Mark Michelson On Jan. 16, 2014, 8:26

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/#review10600 ---

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/#review10601 ---

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread Jonathan Rose
On Jan. 16, 2014, 10:40 a.m., Mark Michelson wrote: /asterisk/trunk/tests/rest_api/mailbox/baseline/mailbox_baseline.py, lines 77-80 https://reviewboard.asterisk.org/r/3118/diff/2/?file=51376#file51376line77 What happens if this is removed? The channel never goes away, StasisEnd

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread Jonathan Rose
On Jan. 16, 2014, 10:47 a.m., opticron wrote: /asterisk/trunk/tests/rest_api/mailbox/baseline/mailbox_baseline.py, lines 38-55 https://reviewboard.asterisk.org/r/3118/diff/2/?file=51376#file51376line38 This could be simplified to: expected = [ {name:

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread Jonathan Rose
On Jan. 16, 2014, 10:40 a.m., Mark Michelson wrote: /asterisk/trunk/tests/rest_api/mailbox/baseline/mailbox_baseline.py, lines 77-80 https://reviewboard.asterisk.org/r/3118/diff/2/?file=51376#file51376line77 What happens if this is removed? Jonathan Rose wrote: The

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- (Updated Jan. 16, 2014, 2:26 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- Review request for Asterisk Developers, Kevin Harwell, Matt Jordan, and

Re: [asterisk-dev] [Code Review] 3118: Testsuite: Add tests for ARI control of external MWI (ARI mailboxes resource)

2014-01-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3118/ --- (Updated Jan. 9, 2014, 5:40 p.m.) Review request for Asterisk Developers,