[asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23164 https://i

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/#review10686 --- /branches/12/apps/app_dial.c

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-24 Thread Matt Jordan
> On Jan. 24, 2014, 1:13 p.m., Mark Michelson wrote: > > /branches/12/apps/app_dial.c, lines 1282-1283 > > > > > > I agree with the removal of ast_channel_publish_dial() here. As you > > pointed out, the status ca

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/ --- (Updated Jan. 24, 2014, 1:33 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/#review10694 --- Ship it! Ship It! - Mark Michelson On Jan. 24, 2014, 7:33 p

Re: [asterisk-dev] [Code Review] 3154: CDRs: fix a variety of dial status problems, h/hangup handler creating CDRs, and block shutdown until in flight CDRs are dispatched

2014-01-31 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3154/ --- (Updated Jan. 31, 2014, 5:40 p.m.) Status -- This change has been mar