Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/ --- (Updated Jan. 31, 2014, 5:04 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/#review10723 --- Ship it! Ship It! - Mark Michelson On Jan. 27, 2014, 9:11 p

Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-28 Thread rmudgett
> On Jan. 28, 2014, 5:37 p.m., Jonathan Rose wrote: > > So one quick question comes to mind... Why does pickupchan simply scan by > > uniqueid if a channel couldn't be found while chanspy has to supply an > > argument to decide on the behavior? The parameter to PickupChan is supposed to be a

Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-28 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/#review10711 --- So one quick question comes to mind... Why does pickupchan sim

Re: [asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/ --- (Updated Jan. 27, 2014, 3:11 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3160: ChanSpy: Add ability to specify channel by uniqueid.

2014-01-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3160/ --- Review request for Asterisk Developers. Bugs: AFS-42 https://issues.as