Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/ --- (Updated Feb. 7, 2014, 8:01 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
On Feb. 4, 2014, 4:53 p.m., Corey Farrell wrote: I like what you've done in general, I think the use of ao2 objects in timing implementations can be possibly stopped. Most (if not all) users of struct ast_timer are already protected by a lock or are owned exclusively by a single

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10761 --- Since this patch is optimazation-related, I have added some

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/ --- (Updated Feb. 5, 2014, 6:17 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10762 --- Ship it! Ship It! - Mark Michelson On Feb. 5, 2014, 6:17

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10763 --- Ship it! /trunk/include/asterisk/timing.h

[asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-04 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10747 --- I like what you've done in general, I think the use of ao2

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-04 Thread Joshua Colp
On Feb. 4, 2014, 4:53 p.m., Corey Farrell wrote: I like what you've done in general, I think the use of ao2 objects in timing implementations can be possibly stopped. Most (if not all) users of struct ast_timer are already protected by a lock or are owned exclusively by a single