Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-03-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- (Updated March 7, 2014, 9:01 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- (Updated Feb. 25, 2014, 12:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
On Feb. 6, 2014, 12:18 a.m., Mark Michelson wrote: /branches/12/main/format_cap_ng.c, lines 316-320 https://reviewboard.asterisk.org/r/3178/diff/1/?file=53410#file53410line316 Should the call to AST_VECTOR_REMOVE_CMP_ORDERED be outside the list traversal? Nope! That macro

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- (Updated Feb. 7, 2014, 2:59 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
On Feb. 7, 2014, 1:39 a.m., rmudgett wrote: /branches/12/main/codec_builtin.c, lines 358-369 https://reviewboard.asterisk.org/r/3178/diff/1/?file=53407#file53407line358 Is there a lpc10_lenght() needed? These implementations come from what we already have. If any are

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
On Feb. 5, 2014, 9:52 p.m., Mark Michelson wrote: /branches/12/include/asterisk/format_cap_ng.h, line 49 https://reviewboard.asterisk.org/r/3178/diff/1/?file=53400#file53400line49 Does ng stand for next generation? If this ends up replacing format_cap.h, would the ng be dropped

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/#review10821 --- /branches/12/include/asterisk/codec.h

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/#review10770 --- All of my comments have to do with implementation details as

[asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- Review request for Asterisk Developers. Repository: Asterisk