Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-13 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- (Updated Feb. 13, 2014, 9:52 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/#review10857 --- Ship it! Ship It! - Mark Michelson On Feb. 12, 2014, 1:12

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- (Updated Feb. 11, 2014, 11:13 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-11 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/#review10855 --- trunk/main/logger.c

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- (Updated Feb. 11, 2014, 7:12 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-11 Thread opticron
On Feb. 11, 2014, 5:09 p.m., Mark Michelson wrote: trunk/main/logger.c, lines 1079-1083 https://reviewboard.asterisk.org/r/3185/diff/4/?file=53838#file53838line1079 This if check can be simplified to if (chan-dynamic (ast_strlen_zero(a-argv[3] || !strncmp(a-argv[3],

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/#review10848 --- Add a blob to CHANGES that summarizes the new feature - Matt

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-07 Thread opticron
On Feb. 5, 2014, 3:38 p.m., Matt Jordan wrote: trunk/main/logger.c, lines 1074-1082 https://reviewboard.asterisk.org/r/3185/diff/1/?file=53452#file53452line1074 This would currently let a user delete a dynamic logger established by a module, i.e., the security logger. That's

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-07 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- (Updated Feb. 7, 2014, 10:20 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-07 Thread Matt Jordan
On Feb. 5, 2014, 3:38 p.m., Matt Jordan wrote: trunk/main/logger.c, lines 1074-1082 https://reviewboard.asterisk.org/r/3185/diff/1/?file=53452#file53452line1074 This would currently let a user delete a dynamic logger established by a module, i.e., the security logger. That's

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-07 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- (Updated Feb. 7, 2014, 10:47 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/ --- Review request for Asterisk Developers. Bugs: AST-1150

Re: [asterisk-dev] [Code Review] 3185: Logger: Allow creation and removal of dynamic logger channels

2014-02-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3185/#review10769 --- trunk/main/logger.c