Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-19 Thread Scott Griepentrog
On March 18, 2014, 4:07 p.m., Corey Farrell wrote: I would like to propose we backport ast_register_cleanup, use that to register format_attr_shutdown. I meantioned this on #asterisk-dev last week, Matt said he could go for this approach if it's the best way to resolve this issue.

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11255 --- I would like to propose we backport ast_register_cleanup, use

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-14 Thread Scott Griepentrog
On March 13, 2014, 3:40 p.m., Corey Farrell wrote: /branches/11/main/format.c, line 1119 https://reviewboard.asterisk.org/r/3209/diff/2/?file=55881#file55881line1119 I think this condition still needs !ast_undestroyed_channels(). If we have undestroyed channels then

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-14 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/ --- (Updated March 14, 2014, 1:05 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-14 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/ --- (Updated March 14, 2014, 1:35 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11211 --- Per a discussion on #asterisk-dev when this was discarded. I

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11180 --- Ship it! Short of protecting the global interfaces container

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-13 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11181 --- /branches/11/main/format.c

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-06 Thread Matt Jordan
On Feb. 12, 2014, 5:12 p.m., Mark Michelson wrote: I'm not a fan of this patch for two reasons: 1) We're preventing a crash by introducing a memory leak. 2) The condition of undestroyed channels doesn't seem like enough to guarantee that the interfaces container is not currently being

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-02-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review10863 --- I'm not a fan of this patch for two reasons: 1) We're

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-02-12 Thread Corey Farrell
On Feb. 12, 2014, 6:12 p.m., Mark Michelson wrote: I'm not a fan of this patch for two reasons: 1) We're preventing a crash by introducing a memory leak. 2) The condition of undestroyed channels doesn't seem like enough to guarantee that the interfaces container is not currently being

[asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-02-11 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/ --- Review request for Asterisk Developers, Corey Farrell and n8ideas. Bugs: