[asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-03 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/ --- Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/#review11101 --- Most of the same comments that apply to 3255 also apply to this

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/ --- (Updated March 6, 2014, 11:44 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/#review11109 --- /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/ext

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread Jonathan Rose
> On March 6, 2014, 2:44 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf, > > line 10 > > > > > > What is this user event here for? It's a remnant of the t

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/ --- (Updated March 6, 2014, 2:59 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/#review11123 --- Ship it! Ship It! - Mark Michelson On March 6, 2014, 8:59 p

Re: [asterisk-dev] [Code Review] 3286: testsuite: chan_pjsip ice crash test for ASTERISK-22911

2014-03-07 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3286/ --- (Updated March 7, 2014, 9:58 a.m.) Status -- This change has been mar