Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-04-08 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3300/ --- (Updated April 8, 2014, 7:59 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-10 Thread Leif Madsen
On March 6, 2014, 9:20 p.m., Mark Michelson wrote: I'm not a fan of this change, because I think it's not really fixing the root problem. bridge_p2p_rtp_write() is called in only one place in res_rtp_asterisk.c, and it's called like this: /* If we are directly bridged to

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-10 Thread Mark Michelson
On March 6, 2014, 9:20 p.m., Mark Michelson wrote: I'm not a fan of this change, because I think it's not really fixing the root problem. bridge_p2p_rtp_write() is called in only one place in res_rtp_asterisk.c, and it's called like this: /* If we are directly bridged to

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3300/#review11120 --- I'm not a fan of this change, because I think it's not really

[asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-05 Thread Russell Bryant
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3300/ --- Review request for Asterisk Developers and leifmadsen. Bugs:

Re: [asterisk-dev] [Code Review] 3300: Don't crash on lack of bridged rtp instance

2014-03-05 Thread Marquis
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3300/#review11073 --- Ship it! Ship It! - Marquis On March 5, 2014, 6:49 p.m.,