---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
(Updated March 7, 2014, 9:07 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11094
---
/branches/12/main/sorcery.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
(Updated March 6, 2014, 5:27 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11103
---
/branches/12/main/sorcery.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
(Updated March 6, 2014, 8:17 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review6
---
Ship it!
Minor issue below.
/branches/12/main/sorcery.c
On March 6, 2014, 3:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
On March 6, 2014, 9:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
On March 6, 2014, 9:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
Review request for Asterisk Developers and Joshua Colp.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11078
---
Another thing I neglected to mention in my review that
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11080
---
/branches/12/main/sorcery.c
On March 5, 2014, 5:50 p.m., Mark Michelson wrote:
Another thing I neglected to mention in my review that concerns me is the
performance hit this patch could cause. Currently, the object fields on a
sorcery object type are an ao2_container that is a linked list. The
algorithm for
13 matches
Mail list logo
