Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-04-11 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/ --- (Updated April 11, 2014, 5:12 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-04-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/#review11555 --- Ship it! Ship It! - Mark Michelson On March 27, 2014, 8:43

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-04-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/#review11548 --- Ship it! Ship It! - opticron On March 27, 2014, 3:43 p.m.,

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/ --- (Updated March 27, 2014, 3:43 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-27 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/#review11391 --- The tests look good, but Matt said to go ahead and add an MWI v

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-27 Thread Matt Jordan
> On March 24, 2014, 3:33 p.m., Mark Michelson wrote: > > Four of the five tests presented here (no_event_header, below_min_expiry, > > unallowed, and unknown_event_package) should use the SIPp test case instead > > of copying and pasting the same run-test script for each one. This requires >

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-26 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/ --- (Updated March 26, 2014, 3:04 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-26 Thread Jonathan Rose
> On March 24, 2014, 3:33 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/sipp/subscribe.xml, > > line 27 > > > > > > You have some problematic XML in thi

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/#review11358 --- Four of the five tests presented here (no_event_header, below_m

Re: [asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

2014-03-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/ --- (Updated March 14, 2014, 2:13 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests

2014-03-14 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3357/ --- Review request for Asterisk Developers, Kevin Harwell and Matt Jordan. Bug