Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-05-03 Thread Matt Jordan
On April 26, 2014, 6:10 a.m., Joshua Colp wrote: After talking on Twitter I believe I understand what is going on here. When you do a sip reload any realtime peers in chan_sip are pruned and removed. This is probably causing the device state to change to an incorrect value which

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-04-27 Thread Matt Jordan
On April 26, 2014, 6:10 a.m., Joshua Colp wrote: After talking on Twitter I believe I understand what is going on here. When you do a sip reload any realtime peers in chan_sip are pruned and removed. This is probably causing the device state to change to an incorrect value which

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-04-26 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/#review11759 --- After talking on Twitter I believe I understand what is going

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-04-02 Thread Shlomi Gutman
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/ --- (Updated April 2, 2014, 12:48 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-31 Thread Shlomi Gutman
On March 30, 2014, 6:44 p.m., Matt Jordan wrote: There are a large number of coding guideline violations in this patch. Please review the Coding Guidelines on the Asterisk wiki [1] and re-submit this patch. Please also clean up any extraneous white space in your patch (which will

[asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-30 Thread Shlomi Gutman
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/ --- Review request for Asterisk Developers. Bugs: ASTERISK-16115

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-03-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3409/#review11445 --- There are a large number of coding guideline violations in