Re: [asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3521/ --- (Updated May 12, 2014, 6:08 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-12 Thread rmudgett
> On May 7, 2014, 10:49 a.m., Matt Jordan wrote: > > /branches/1.8/channels/sig_pri.c, lines 5275-5290 > > > > > > This is really hard to read, particularly with the level of indentation > > that is required here.

Re: [asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-08 Thread Matt Jordan
> On May 7, 2014, 10:49 a.m., Matt Jordan wrote: > > /branches/1.8/channels/sig_pri.c, lines 5275-5290 > > > > > > This is really hard to read, particularly with the level of indentation > > that is required here.

Re: [asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-07 Thread rmudgett
> On May 7, 2014, 10:49 a.m., Matt Jordan wrote: > > /branches/1.8/channels/sig_pri.c, lines 5275-5290 > > > > > > This is really hard to read, particularly with the level of indentation > > that is required here.

Re: [asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3521/#review11837 --- /branches/1.8/channels/sig_pri.c

[asterisk-dev] [Code Review] 3521: chan_dahdi/sig_pri: Prevent unnecessary PROGRESS events when overlap dialing is enabled.

2014-05-01 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3521/ --- Review request for Asterisk Developers. Bugs: AST-1338 https://issues.