Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-23 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 23, 2014, 7:29 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/#review11955 --- Ship it! I still have some mixed feelings about the way this t

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-20 Thread opticron
> On May 20, 2014, 12:34 p.m., Matt Jordan wrote: > > I may be a bit dense on this, but I'm still confused as to what legs are > > getting transferred in this scenario. > > > > You have two SIPp scenarios that are actually doing the REFER request and > > some portion of the attended transfer.

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-20 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 20, 2014, 1:37 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/#review11922 --- I may be a bit dense on this, but I'm still confused as to what

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-20 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 20, 2014, 9:32 a.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 2:27 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 2:25 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
> On May 12, 2014, 8:58 p.m., Matt Jordan wrote: > > asterisk/trunk/lib/python/asterisk/ari.py, lines 511-523 > > > > > > This should not be bundled with EventWatcher. Separation of concerns > > takes a real beatin

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- (Updated May 19, 2014, 1:02 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-19 Thread opticron
> On May 12, 2014, 8:58 p.m., Matt Jordan wrote: > > I feel like we're missing a SIPp scenario here. We have the initial > > receiver of the call, and we have the scenario that sends the REFER request > > - but where is the second SIP channel from the initiator of the transfer, > > and where i

Re: [asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/#review11877 --- I feel like we're missing a SIPp scenario here. We have the ini

[asterisk-dev] [Code Review] 3525: Testsuite: Fix ARI attended transfer test

2014-05-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3525/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-236