Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/ --- (Updated June 8, 2014, 1:11 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/#review12066 --- Ship it! Some trivial nits. /branches/12/include/asterisk/ch

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/ --- (Updated June 5, 2014, 4:27 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

> On June 5, 2014, 1:20 p.m., rmudgett wrote: > > /branches/12/main/bridge_channel.c, lines 1759-1760 > > > > > > I prefer breaking long lines before binary operators because the > > operator may be overlooked if

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

> On June 5, 2014, 12:45 p.m., Mark Michelson wrote: > > /branches/12/include/asterisk/channel.h, line 4300 > > > > > > It's a tough thing to do, but I'd like to see this function's name > > imply that channels th

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/#review12056 --- /branches/12/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

> On June 5, 2014, 5:45 p.m., Mark Michelson wrote: > > /branches/12/include/asterisk/channel.h, line 4300 > > > > > > It's a tough thing to do, but I'd like to see this function's name > > imply that channels tha

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

ast_channel_exit_bridge? Phil Mickelson On Thu, Jun 5, 2014 at 1:58 PM, Matt Jordan wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3585/ > > On June 5th, 2014, 12:45 p.m. CDT, *Mark Michelson* wrote: > > /branches/12/include/aster

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

> On June 5, 2014, 12:45 p.m., Mark Michelson wrote: > > /branches/12/include/asterisk/channel.h, line 4300 > > > > > > It's a tough thing to do, but I'd like to see this function's name > > imply that channels th

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

> On June 5, 2014, 5:45 p.m., Mark Michelson wrote: > > /branches/12/main/channel.c, lines 10156-10161 > > > > > > I reccomend re-writing this to be: > > > > hangup_flags = ast_channel_softhangup_internal

Re: [asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/#review12053 --- /branches/12/include/asterisk/channel.h

[asterisk-dev] [Code Review] 3585: bridge_native_rtp: Reconfigure bridge on removal of framehook - take 2

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3585/ --- Review request for Asterisk Developers. Repository: Asterisk Description