Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated July 3, 2014, 4:38 p.m.) Status -- This change has been
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 24, 2014, 6:53 a.m.) Review request for Asterisk
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 24, 2014, 6:59 a.m.) Review request for Asterisk
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
On June 19, 2014, 11:05 p.m., rmudgett wrote: /branches/11/channels/chan_dahdi.c, line 12921 https://reviewboard.asterisk.org/r/3633/diff/1/?file=59792#file59792line12921 Rename alwayssendprogress to always_send_progress. It is a whole lot easier to read that way and you might
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12294 --- Ship it! I'll commit the patch. - rmudgett On June 24,
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 20, 2014, 11:24 a.m.) Review request for Asterisk
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12257 --- /branches/11/UPGRADE.txt
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
On June 20, 2014, 2:56 p.m., rmudgett wrote: /branches/11/UPGRADE.txt, lines 23-30 https://reviewboard.asterisk.org/r/3633/diff/2/?file=59969#file59969line23 Changing UPGRADE is not necessary. This is fixing a regression. Documenting the new option is only needed in
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
On June 20, 2014, 2:56 p.m., rmudgett wrote: /branches/11/UPGRADE.txt, lines 23-30 https://reviewboard.asterisk.org/r/3633/diff/2/?file=59969#file59969line23 Changing UPGRADE is not necessary. This is fixing a regression. Documenting the new option is only needed in
[asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- Review request for Asterisk Developers. Bugs: /, ASTERISK-23897 and
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 19, 2014, 6:17 a.m.) Review request for Asterisk
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12193 --- Update: * The sample config with the new option * The
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 19, 2014, 9:20 a.m.) Review request for Asterisk
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
On June 19, 2014, 9:20 a.m., Matt Jordan wrote: Update: * The sample config with the new option * The UPGRADE.txt file documenting the new option This patch should also be written against 1.8, as that is where this issue was first introduced. - Matt
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/#review12241 --- The always_send_progress option needs to be documented in the
Re: [asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3633/ --- (Updated June 20, 2014, 5:28 a.m.) Review request for Asterisk
