[asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-19 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23905 https://i

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/#review12192 --- branches/12/main/tcptls.c

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-19 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/ --- (Updated June 19, 2014, 2:34 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-20 Thread Alexander Traud
> On June 19, 2014, 2:13 p.m., Matt Jordan wrote: > > branches/12/main/tcptls.c, lines 435-447 > > > > > > Given how tricky it is to set up TLS support, I'd go ahead and add an > > off nominal handler for BIO_new_f

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-20 Thread Matt Jordan
> On June 19, 2014, 9:13 a.m., Matt Jordan wrote: > > branches/12/main/tcptls.c, lines 435-447 > > > > > > Given how tricky it is to set up TLS support, I'd go ahead and add an > > off nominal handler for BIO_new_f

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-20 Thread Alexander Traud
> On June 19, 2014, 2:13 p.m., Matt Jordan wrote: > > branches/12/main/tcptls.c, lines 435-447 > > > > > > Given how tricky it is to set up TLS support, I'd go ahead and add an > > off nominal handler for BIO_new_f

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-06-28 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/#review12381 --- Ship it! I'll relent on my desire for better error messages. (

Re: [asterisk-dev] [Code Review] 3647: Enable Forward Secrecy (PFS) in TLS

2014-07-03 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3647/ --- (Updated July 3, 2014, 7:10 a.m.) Status -- This change has been mark