[asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23866 https://i

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/#review12217 --- /team/group/rls/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Mark Michelson
> On June 19, 2014, 6:12 p.m., Matt Jordan wrote: > > /team/group/rls/res/res_pjsip_pubsub.c, lines 2087-2088 > > > > > > You may want to provide a min/max range for this option. Otherwise, > > someone may provide

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Matt Jordan
> On June 19, 2014, 1:12 p.m., Matt Jordan wrote: > > /team/group/rls/res/res_pjsip_pubsub.c, lines 2087-2088 > > > > > > You may want to provide a min/max range for this option. Otherwise, > > someone may provide

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/#review12229 --- /team/group/rls/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/ --- (Updated June 19, 2014, 9 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/#review12236 --- Ship it! /team/group/rls/res/res_pjsip_pubsub.c

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/ --- (Updated June 19, 2014, 10:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-19 Thread Mark Michelson
> On June 19, 2014, 9:37 p.m., Matt Jordan wrote: > > /team/group/rls/res/res_pjsip_pubsub.c, lines 2085-2086 > > > > > > I'm not sure if it will end up mattering, but if event is less than the > > size of the cha

Re: [asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

2014-06-20 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3648/ --- (Updated June 20, 2014, 10:33 a.m.) Status -- This change has been ma