Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 7:47 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12392 --- Ship it! Ship It! - Matt Jordan On June 30, 2014, 10:20 a.m

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 3:20 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12391 --- /branches/12/contrib/ast-db-manage/config/versions/51f8cb66540

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- (Updated June 30, 2014, 2:31 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Joshua Colp
> On June 30, 2014, 1:12 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_sdp_rtp.c, lines 541-545 > > > > > > That seems like an odd setting return here. > > > > Why wouldn't this return AST_SIP_MED

Re: [asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/#review12389 --- /branches/12/res/res_pjsip.c

[asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

2014-06-28 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3686/ --- Review request for Asterisk Developers. Repository: Asterisk Description