Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/ --- (Updated July 9, 2014, 5:51 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/#review12506 --- /team/group/media_formats-reviewed-trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-07 Thread Matt Jordan
On July 7, 2014, 10:50 a.m., Matt Jordan wrote: The findings here were resolved in https://reviewboard.asterisk.org/r/3722 - Matt --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-07 Thread Matt Jordan
On July 2, 2014, 3:25 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/res/res_format_attr_celt.c, lines 48-53 https://reviewboard.asterisk.org/r/3703/diff/2/?file=62050#file62050line48 All format_destroy callbacks are identical. I think it would be better

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/ --- (Updated July 3, 2014, 12:15 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-03 Thread Joshua Colp
On July 2, 2014, 8:25 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/res/res_format_attr_silk.c, lines 269-281 https://reviewboard.asterisk.org/r/3703/diff/2/?file=62054#file62054line269 Just a thought, what if this used the ACO model of creating an

[asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23957

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/#review12440 --- I still need review the res_format_attr modules again,

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/ --- (Updated July 2, 2014, 7:24 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3703/#review12443 ---

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Joshua Colp
On July 2, 2014, 8:25 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/include/asterisk/format.h, lines 51-60 https://reviewboard.asterisk.org/r/3703/diff/2/?file=62046#file62046line51 Every format_clone function is identical, except for the obvious

Re: [asterisk-dev] [Code Review] 3703: media_formats: Move format attribute modules over, tweak API, and fix some bugs.

2014-07-02 Thread Corey Farrell
On July 2, 2014, 4:25 p.m., Corey Farrell wrote: /team/group/media_formats-reviewed-trunk/include/asterisk/format.h, lines 51-60 https://reviewboard.asterisk.org/r/3703/diff/2/?file=62046#file62046line51 Every format_clone function is identical, except for the obvious