Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/ --- (Updated July 7, 2014, 11:05 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/#review12501 --- Ship it! Ship It! - Matt Jordan On July 7, 2014, 9:39 a.m.,

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/ --- (Updated July 7, 2014, 2:39 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/#review12500 --- Ship it! /branches/12/res/res_pjsip_dialog_info_body_generato

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

> On July 4, 2014, 3:43 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_dialog_info_body_generator.c, lines 152-155 > > > > > > Doxygen comments on these #defines would be nice, as they aren't > > 'obvious'

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

> On July 4, 2014, 3:43 p.m., Matt Jordan wrote: > > /branches/12/res/res_pjsip_dialog_info_body_generator.c, lines 152-155 > > > > > > Doxygen comments on these #defines would be nice, as they aren't > > 'obvious'

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/#review12492 --- Make sure to update the CHANGES file! /branches/12/res/res_pj

Re: [asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/#review12449 --- Ship it! Tested on my Grandstreams. Ship It! - George Joseph

[asterisk-dev] [Code Review] 3705: res_pjsip_dialog_info_body_generator: Add dialog-info+xml implementation and tweak res_pjsip_pubsub to support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3705/ --- Review request for Asterisk Developers. Bugs: ASTERISK-21443 https://i