Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread Olle E. Johansson
On 04 Jul 2014, at 14:41, wdoekes wrote: > And generally there is a period of rest between submitting the review and > committing the code, so you would normally have been in time for review. > I would kindly like to remind everyone about this. Especially if it affects release versions. Hav

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread wdoekes
> On July 4, 2014, 7:48 a.m., Alexander Traud wrote: > > As I am the contributor of the original patch: Argg, I thought I > > double-checked all symbols. Anyway, mistakes happen. > > I am not sure why I wasn’t invited as reviewer for this one here. > > > > EC_KEY_new_by_curve_name() is the only

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread Alexander Traud
> On July 4, 2014, 7:48 a.m., Alexander Traud wrote: > > As I am the contributor of the original patch: Argg, I thought I > > double-checked all symbols. Anyway, mistakes happen. > > I am not sure why I wasn’t invited as reviewer for this one here. > > > > EC_KEY_new_by_curve_name() is the only

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread wdoekes
> On July 4, 2014, 7:48 a.m., Alexander Traud wrote: > > As I am the contributor of the original patch: Argg, I thought I > > double-checked all symbols. Anyway, mistakes happen. > > I am not sure why I wasn’t invited as reviewer for this one here. > > > > EC_KEY_new_by_curve_name() is the only

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread wdoekes
> On July 4, 2014, 7:48 a.m., Alexander Traud wrote: > > As I am the contributor of the original patch: Argg, I thought I > > double-checked all symbols. Anyway, mistakes happen. > > I am not sure why I wasn’t invited as reviewer for this one here. > > > > EC_KEY_new_by_curve_name() is the only

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-04 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3709/#review12483 --- As I am the contributor of the original patch: Argg, I thought

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-03 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3709/ --- (Updated July 3, 2014, 11:55 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3709/#review12475 --- Ship it! Ship It! - Joshua Colp On July 3, 2014, 4:36 p.m.,

[asterisk-dev] [Code Review] 3709: configure.ac: Check OpenSSL for support of Elliptic Curve cryptography

2014-07-03 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3709/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23905 https://i