Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-06 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/ --- (Updated July 6, 2014, 9:13 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/#review12491 --- Ship it! Ship It! - Joshua Colp On July 4, 2014, 12:45 p.m.

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-04 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/ --- (Updated July 4, 2014, 7:45 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-04 Thread Joshua Colp
> On July 4, 2014, 11:43 a.m., Joshua Colp wrote: > > /branches/12/res/ari/resource_channels.c, line 869 > > > > > > You need to check if local_peer exists here as it won't for non-Local > > and following stuff ass

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-04 Thread Matt Jordan
> On July 4, 2014, 6:43 a.m., Joshua Colp wrote: > > /branches/12/res/ari/resource_channels.c, line 869 > > > > > > You need to check if local_peer exists here as it won't for non-Local > > and following stuff assu

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/#review12486 --- /branches/12/res/ari/resource_channels.c

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-03 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/ --- (Updated July 3, 2014, 10:01 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-03 Thread Matt Jordan
> On July 3, 2014, 4:12 p.m., Joshua Colp wrote: > > /branches/12/res/ari/resource_channels.c, line 882 > > > > > > Holding the channel lock while subscribing is hazardous. The > > stasis_app_subscribe will interna

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-03 Thread Matt Jordan
> On July 3, 2014, 4:12 p.m., Joshua Colp wrote: > > /branches/12/res/ari/resource_channels.c, line 882 > > > > > > Holding the channel lock while subscribing is hazardous. The > > stasis_app_subscribe will interna

Re: [asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/#review12479 --- /branches/12/res/ari/resource_channels.c

[asterisk-dev] [Code Review] 3710: ARI: Subscribe to both halves of a Local channel pair when originating a Local channel to a Stasis application; clean up subscription leak

2014-07-03 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3710/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23939 https://i