Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/#review12594 --- Closing out in favour of Corey's patch on https://reviewboard.

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/ --- (Updated July 12, 2014, 3:48 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-12 Thread Matt Jordan
> On July 11, 2014, 10:01 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 > > > > > > This reorder will prevent ref_log from recording a double-free. > > >

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Corey Farrell
> On July 11, 2014, 11:01 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 > > > > > > This reorder will prevent ref_log from recording a double-free. > > >

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Matt Jordan
> On July 11, 2014, 10:01 p.m., Corey Farrell wrote: > > /team/group/media_formats-reviewed-trunk/main/astobj2.c, lines 503-507 > > > > > > This reorder will prevent ref_log from recording a double-free. > > >

Re: [asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/#review12579 --- I think the way this has to be fixes is to simply get rid of th

[asterisk-dev] [Code Review] 3752: astobj2: Fix race condition in ref_debug log

2014-07-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3752/ --- Review request for Asterisk Developers and Corey Farrell. Repository: Aste