Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- (Updated July 25, 2014, 9:27 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/#review12847 --- Ship it! Ship It! - Joshua Colp On July 21, 2014, 4:58

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-24 Thread Joshua Colp
On July 21, 2014, 5:49 p.m., Mark Michelson wrote: /trunk/main/loader.c, lines 1001-1005 https://reviewboard.asterisk.org/r/3777/diff/2/?file=64886#file64886line1001 Feel free to cringe at this suggestion, but since you've created both an AST_DLLIST_ENTRY and an AST_LIST_ENTRY on

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-21 Thread Matt Jordan
On July 16, 2014, 7:52 p.m., Corey Farrell wrote: /trunk/main/loader.c, lines 606-607 https://reviewboard.asterisk.org/r/3777/diff/1/?file=63328#file63328line606 Not sure we want this, but if we do I think it should be ast_debug. It will be useful when debugging ref leaks in the

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- (Updated July 21, 2014, 11:58 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-21 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/#review12789 --- /trunk/main/loader.c

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-21 Thread Matt Jordan
On July 21, 2014, 12:49 p.m., Mark Michelson wrote: /trunk/main/loader.c, lines 1001-1005 https://reviewboard.asterisk.org/r/3777/diff/2/?file=64886#file64886line1001 Feel free to cringe at this suggestion, but since you've created both an AST_DLLIST_ENTRY and an AST_LIST_ENTRY

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-16 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/#review12702 --- This file is terrible when it comes to {} around code blocks.

Re: [asterisk-dev] [Code Review] 3777: module loader: Unload modules in reverse order of their start order

2014-07-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3777/ --- (Updated July 14, 2014, 3:16 p.m.) Review request for Asterisk