Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-06 Thread dtryba
On Aug. 5, 2014, 10:58 a.m., wdoekes wrote: http://lists.digium.com/pipermail/asterisk-commits/2014-August/069629.html It'd be nice if the documentation got updated too... I know it's in an illogical place, in funcs/func_channel.c, but it should be updated nevertheless. /w

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-06 Thread dtryba
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- (Updated Aug. 6, 2014, 10:01 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-06 Thread dtryba
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- (Updated Aug. 6, 2014, 10:32 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-05 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/#review12979 ---

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-08-04 Thread dtryba
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- (Updated Aug. 4, 2014, 3:25 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-07-22 Thread dtryba
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- (Updated July 22, 2014, 11:44 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-07-22 Thread dtryba
On July 21, 2014, 6:31 p.m., Mark Michelson wrote: /trunk/channels/sip/dialplan_functions.c, line 80 https://reviewboard.asterisk.org/r/3781/diff/1/?file=63311#file63311line80 There's an inline function in include/asterisk/netsock2.h called ast_sockaddr_stringify_port() that you

[asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-07-21 Thread dtryba
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24040

Re: [asterisk-dev] [Code Review] 3781: Retrieve the source port of an incoming (chan_sip) SIP invite

2014-07-21 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3781/#review12791 --- Ship it! /trunk/channels/sip/dialplan_functions.c